From 01707907cd1b8bf0f03466135276a7d57a4b3252 Mon Sep 17 00:00:00 2001 From: Yuhang Zhao <2546789017@qq.com> Date: Fri, 24 Apr 2020 13:02:13 +0800 Subject: [PATCH] WIP. Adapt to Windows Terminal style. Don't remove the window frame totally, only remove the title bar instead (including the top border). We can resize outside our window just like any other normal window in this way. And many strange problems caused by the removal of window frame are gone such as background flicker. However, we will need to paint the top frame border ourself. Otherwise the window doesn't look very good. Signed-off-by: Yuhang Zhao <2546789017@qq.com> --- main.cpp | 18 +- winnativeeventfilter.cpp | 1511 +++++++++++++++++++------------------- winnativeeventfilter.h | 10 - 3 files changed, 787 insertions(+), 752 deletions(-) diff --git a/main.cpp b/main.cpp index 354007d..f9fc277 100644 --- a/main.cpp +++ b/main.cpp @@ -1,7 +1,12 @@ -#include "framelesshelper.h" - #include #include +#include + +#ifdef Q_OS_WINDOWS +#include "winnativeeventfilter.h" +#else +#include "framelesshelper.h" +#endif int main(int argc, char *argv[]) { #if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) @@ -20,10 +25,19 @@ int main(int argc, char *argv[]) { QApplication application(argc, argv); +#ifdef Q_OS_WINDOWS + // Do this AFTER the Q(Gui)Application is constructed! + WinNativeEventFilter::install(); +#else FramelessHelper helper; +#endif + QWindow window; QWidget widget; +#ifndef Q_OS_WINDOWS helper.setFramelessWindows({&widget}); +#endif + window.show(); widget.show(); return QApplication::exec(); diff --git a/winnativeeventfilter.cpp b/winnativeeventfilter.cpp index 21457bf..e4e82a1 100644 --- a/winnativeeventfilter.cpp +++ b/winnativeeventfilter.cpp @@ -31,6 +31,20 @@ #include #include +#ifdef IsMinimized +#undef IsMinimized +#endif + +// Only available since Windows 2000 +#define IsMinimized m_lpIsIconic + +#ifdef IsMaximized +#undef IsMaximized +#endif + +// Only available since Windows 2000 +#define IsMaximized m_lpIsZoomed + #ifndef GET_X_LPARAM // Only available since Windows 2000 #define GET_X_LPARAM(lp) ((int)(short)LOWORD(lp)) @@ -41,6 +55,11 @@ #define GET_Y_LPARAM(lp) ((int)(short)HIWORD(lp)) #endif +#ifndef GetStockBrush +// Only available since Windows 2000 +#define GetStockBrush(i) ((HBRUSH)m_lpGetStockObject(i)) +#endif + #ifndef ABM_GETSTATE // Only available since Windows XP #define ABM_GETSTATE 0x00000004 @@ -76,6 +95,16 @@ #define ABE_BOTTOM 3 #endif +#ifndef BPPF_ERASE +// Only available since Windows Vista +#define BPPF_ERASE 0x0001 +#endif + +#ifndef BPPF_NOCLIP +// Only available since Windows Vista +#define BPPF_NOCLIP 0x0002 +#endif + #ifndef USER_DEFAULT_SCREEN_DPI // Only available since Windows Vista #define USER_DEFAULT_SCREEN_DPI 96 @@ -111,18 +140,6 @@ #define ABM_GETAUTOHIDEBAREX 0x0000000b #endif -#ifdef IsMinimized -#undef IsMinimized -#endif - -#define IsMinimized m_lpIsIconic - -#ifdef IsMaximized -#undef IsMaximized -#endif - -#define IsMaximized m_lpIsZoomed - #ifndef WNEF_GENERATE_WINAPI #define WNEF_GENERATE_WINAPI(funcName, resultType, ...) \ using _WNEF_WINAPI_##funcName = resultType(WINAPI *)(__VA_ARGS__); \ @@ -142,17 +159,21 @@ namespace { -using MONITOR_DPI_TYPE = enum _MONITOR_DPI_TYPE { - MDT_EFFECTIVE_DPI = 0, - MDT_ANGULAR_DPI = 1, - MDT_RAW_DPI = 2, - MDT_DEFAULT = MDT_EFFECTIVE_DPI -}; +const UINT m_defaultDotsPerInch = USER_DEFAULT_SCREEN_DPI; + +const qreal m_defaultDevicePixelRatio = 1.0; + +int m_borderWidth = -1, m_borderHeight = -1, m_titlebarHeight = -1; + +using HPAINTBUFFER = HANDLE; + +using MONITOR_DPI_TYPE = enum _MONITOR_DPI_TYPE { MDT_EFFECTIVE_DPI = 0 }; using DWMNCRENDERINGPOLICY = enum _DWMNCRENDERINGPOLICY { DWMNCRP_ENABLED = 2 }; using DWMWINDOWATTRIBUTE = enum _DWMWINDOWATTRIBUTE { - DWMWA_NCRENDERING_POLICY = 2 + DWMWA_NCRENDERING_POLICY = 2, + DWMWA_EXTENDED_FRAME_BOUNDS = 9 }; using MARGINS = struct _MARGINS { @@ -177,6 +198,22 @@ using PROCESS_DPI_AWARENESS = enum _PROCESS_DPI_AWARENESS { PROCESS_PER_MONITOR_DPI_AWARE = 2 }; +using BP_BUFFERFORMAT = enum _BP_BUFFERFORMAT { BPBF_TOPDOWNDIB = 2 }; + +using BLENDFUNCTION = struct _BLENDFUNCTION { + BYTE BlendOp; + BYTE BlendFlags; + BYTE SourceConstantAlpha; + BYTE AlphaFormat; +}; + +using BP_PAINTPARAMS = struct _BP_PAINTPARAMS { + DWORD cbSize; + DWORD dwFlags; + const RECT *prcExclude; + const BLENDFUNCTION *pBlendFunction; +}; + WNEF_GENERATE_WINAPI(GetSystemDpiForProcess, UINT, HANDLE) WNEF_GENERATE_WINAPI(GetDpiForWindow, UINT, HWND) WNEF_GENERATE_WINAPI(GetDpiForSystem, UINT) @@ -207,15 +244,29 @@ WNEF_GENERATE_WINAPI(EqualRect, BOOL, CONST RECT *, CONST RECT *) #ifdef Q_PROCESSOR_X86_64 WNEF_GENERATE_WINAPI(GetWindowLongPtrW, LONG_PTR, HWND, int) WNEF_GENERATE_WINAPI(SetWindowLongPtrW, LONG_PTR, HWND, int, LONG_PTR) +WNEF_GENERATE_WINAPI(GetClassLongPtrW, ULONG_PTR, HWND, int) WNEF_GENERATE_WINAPI(SetClassLongPtrW, ULONG_PTR, HWND, int, LONG_PTR) #else +#ifdef LONG_PTR +#undef LONG_PTR +#endif #define LONG_PTR LONG WNEF_GENERATE_WINAPI(GetWindowLongW, LONG_PTR, HWND, int) WNEF_GENERATE_WINAPI(SetWindowLongW, LONG_PTR, HWND, int, LONG_PTR) #define m_lpGetWindowLongPtrW m_lpGetWindowLongW #define m_lpSetWindowLongPtrW m_lpSetWindowLongW +#ifdef GWLP_USERDATA +#undef GWLP_USERDATA +#endif +#define GWLP_USERDATA GWL_USERDATA +WNEF_GENERATE_WINAPI(GetClassLongW, DWORD, HWND, int) WNEF_GENERATE_WINAPI(SetClassLongW, DWORD, HWND, int, LONG_PTR) +#define m_lpGetClassLongPtrW m_lpGetClassLongW #define m_lpSetClassLongPtrW m_lpSetClassLongW +#ifdef GCLP_HBRBACKGROUND +#undef GCLP_HBRBACKGROUND +#endif +#define GCLP_HBRBACKGROUND GCL_HBRBACKGROUND #endif WNEF_GENERATE_WINAPI(FindWindowW, HWND, LPCWSTR, LPCWSTR) WNEF_GENERATE_WINAPI(MonitorFromWindow, HMONITOR, HWND, DWORD) @@ -241,14 +292,120 @@ WNEF_GENERATE_WINAPI(GetProcessDpiAwareness, HRESULT, HANDLE, WNEF_GENERATE_WINAPI(IsProcessDPIAware, BOOL) WNEF_GENERATE_WINAPI(D2D1CreateFactory, HRESULT, D2D1_FACTORY_TYPE, REFIID, CONST D2D1_FACTORY_OPTIONS *, void **) +WNEF_GENERATE_WINAPI(AdjustWindowRectEx, BOOL, LPRECT, DWORD, BOOL, DWORD) +WNEF_GENERATE_WINAPI(AdjustWindowRectExForDpi, BOOL, LPRECT, DWORD, BOOL, DWORD, + UINT) +WNEF_GENERATE_WINAPI(DwmDefWindowProc, BOOL, HWND, UINT, WPARAM, LPARAM, + LRESULT *) +WNEF_GENERATE_WINAPI(DwmGetWindowAttribute, HRESULT, HWND, DWORD, PVOID, DWORD) +WNEF_GENERATE_WINAPI(GetStockObject, HGDIOBJ, int) +WNEF_GENERATE_WINAPI(BufferedPaintSetAlpha, HRESULT, HPAINTBUFFER, CONST RECT *, + BYTE) +WNEF_GENERATE_WINAPI(EndBufferedPaint, HRESULT, HPAINTBUFFER, BOOL) +WNEF_GENERATE_WINAPI(BeginBufferedPaint, HPAINTBUFFER, HDC, CONST RECT *, + BP_BUFFERFORMAT, BP_PAINTPARAMS *, HDC *) +WNEF_GENERATE_WINAPI(CreateRectRgnIndirect, HRGN, CONST RECT *) + +void ResolveWin32APIs() { + static bool resolved = false; + if (resolved) { + return; + } + resolved = true; + // Available since Windows 2000. + WNEF_RESOLVE_WINAPI(User32, AdjustWindowRectEx) + WNEF_RESOLVE_WINAPI(User32, EndPaint) + WNEF_RESOLVE_WINAPI(User32, BeginPaint) + WNEF_RESOLVE_WINAPI(User32, FillRect) + WNEF_RESOLVE_WINAPI(User32, GetWindowInfo) + WNEF_RESOLVE_WINAPI(User32, IsWindow) + WNEF_RESOLVE_WINAPI(User32, SetWindowRgn) + WNEF_RESOLVE_WINAPI(User32, InvalidateRect) + WNEF_RESOLVE_WINAPI(User32, UpdateWindow) + WNEF_RESOLVE_WINAPI(User32, SetWindowPos) + WNEF_RESOLVE_WINAPI(User32, SendMessageW) + WNEF_RESOLVE_WINAPI(User32, GetDesktopWindow) + WNEF_RESOLVE_WINAPI(User32, GetAncestor) + WNEF_RESOLVE_WINAPI(User32, DefWindowProcW) + WNEF_RESOLVE_WINAPI(User32, SetLayeredWindowAttributes) + WNEF_RESOLVE_WINAPI(User32, MoveWindow) + WNEF_RESOLVE_WINAPI(User32, IsZoomed) + WNEF_RESOLVE_WINAPI(User32, IsIconic) + WNEF_RESOLVE_WINAPI(User32, GetSystemMetrics) + WNEF_RESOLVE_WINAPI(User32, GetDC) + WNEF_RESOLVE_WINAPI(User32, ReleaseDC) + WNEF_RESOLVE_WINAPI(User32, RedrawWindow) + WNEF_RESOLVE_WINAPI(User32, GetClientRect) + WNEF_RESOLVE_WINAPI(User32, GetWindowRect) + WNEF_RESOLVE_WINAPI(User32, ScreenToClient) + WNEF_RESOLVE_WINAPI(User32, EqualRect) +#ifdef Q_PROCESSOR_X86_64 + WNEF_RESOLVE_WINAPI(User32, GetWindowLongPtrW) + WNEF_RESOLVE_WINAPI(User32, SetWindowLongPtrW) + WNEF_RESOLVE_WINAPI(User32, GetClassLongPtrW) + WNEF_RESOLVE_WINAPI(User32, SetClassLongPtrW) +#else + WNEF_RESOLVE_WINAPI(User32, GetWindowLongW) + WNEF_RESOLVE_WINAPI(User32, SetWindowLongW) + WNEF_RESOLVE_WINAPI(User32, GetClassLongW) + WNEF_RESOLVE_WINAPI(User32, SetClassLongW) +#endif + WNEF_RESOLVE_WINAPI(User32, FindWindowW) + WNEF_RESOLVE_WINAPI(User32, MonitorFromWindow) + WNEF_RESOLVE_WINAPI(User32, GetMonitorInfoW) + WNEF_RESOLVE_WINAPI(Gdi32, GetDeviceCaps) + WNEF_RESOLVE_WINAPI(Gdi32, CreateSolidBrush) + WNEF_RESOLVE_WINAPI(Gdi32, DeleteObject) + WNEF_RESOLVE_WINAPI(Gdi32, GetStockObject) + WNEF_RESOLVE_WINAPI(Gdi32, CreateRectRgnIndirect) + // Available since Windows XP. + WNEF_RESOLVE_WINAPI(Shell32, SHAppBarMessage) + WNEF_RESOLVE_WINAPI(Kernel32, GetCurrentProcess) + // Available since Windows Vista. + WNEF_RESOLVE_WINAPI(User32, IsProcessDPIAware) + WNEF_RESOLVE_WINAPI(Dwmapi, DwmGetWindowAttribute) + WNEF_RESOLVE_WINAPI(Dwmapi, DwmIsCompositionEnabled) + WNEF_RESOLVE_WINAPI(Dwmapi, DwmExtendFrameIntoClientArea) + WNEF_RESOLVE_WINAPI(Dwmapi, DwmSetWindowAttribute) + WNEF_RESOLVE_WINAPI(Dwmapi, DwmDefWindowProc) + WNEF_RESOLVE_WINAPI(UxTheme, IsThemeActive) + WNEF_RESOLVE_WINAPI(UxTheme, BufferedPaintSetAlpha) + WNEF_RESOLVE_WINAPI(UxTheme, EndBufferedPaint) + WNEF_RESOLVE_WINAPI(UxTheme, BeginBufferedPaint) + // Available since Windows 7. + WNEF_RESOLVE_WINAPI(D2D1, D2D1CreateFactory) + // Available since Windows 8.1 + if (QOperatingSystemVersion::current() >= + QOperatingSystemVersion::Windows8_1) { + WNEF_RESOLVE_WINAPI(SHCore, GetDpiForMonitor) + WNEF_RESOLVE_WINAPI(SHCore, GetProcessDpiAwareness) + } + // Available since Windows 10, version 1607 (10.0.14393) + if (QOperatingSystemVersion::current() >= + QOperatingSystemVersion(QOperatingSystemVersion::Windows, 10, 0, + 14393)) { + WNEF_RESOLVE_WINAPI(User32, GetDpiForWindow) + WNEF_RESOLVE_WINAPI(User32, GetDpiForSystem) + WNEF_RESOLVE_WINAPI(User32, GetSystemMetricsForDpi) + WNEF_RESOLVE_WINAPI(User32, AdjustWindowRectExForDpi) + } + // Available since Windows 10, version 1803 (10.0.17134) + if (QOperatingSystemVersion::current() >= + QOperatingSystemVersion(QOperatingSystemVersion::Windows, 10, 0, + 17134)) { + WNEF_RESOLVE_WINAPI(User32, GetSystemDpiForProcess) + } +} BOOL IsDwmCompositionEnabled() { // Since Win8, DWM composition is always enabled and can't be disabled. + // In other words, DwmIsCompositionEnabled will always return TRUE on + // systems newer than Win7. BOOL enabled = FALSE; return SUCCEEDED(m_lpDwmIsCompositionEnabled(&enabled)) && enabled; } -BOOL IsFullScreened(HWND handle) { +BOOL IsFullScreen(HWND handle) { if (handle && m_lpIsWindow(handle)) { WINDOWINFO windowInfo; SecureZeroMemory(&windowInfo, sizeof(windowInfo)); @@ -260,7 +417,7 @@ BOOL IsFullScreened(HWND handle) { const HMONITOR monitor = m_lpMonitorFromWindow(handle, MONITOR_DEFAULTTONEAREST); m_lpGetMonitorInfoW(monitor, &monitorInfo); - // The only way to judge whether a window is fullscreened or not + // The only way to judge whether a window is fullscreen or not // is to compare it's size with the screen's size, there is no official // Win32 API to do this for us. return m_lpEqualRect(&windowInfo.rcWindow, &monitorInfo.rcMonitor) || @@ -269,7 +426,7 @@ BOOL IsFullScreened(HWND handle) { return FALSE; } -BOOL IsWindowTopLevel(HWND handle) { +BOOL IsTopLevel(HWND handle) { if (handle && m_lpIsWindow(handle)) { if (m_lpGetWindowLongPtrW(handle, GWL_STYLE) & WS_CHILD) { return FALSE; @@ -283,535 +440,7 @@ BOOL IsWindowTopLevel(HWND handle) { return FALSE; } -// The thickness of an auto-hide taskbar in pixels. -const int kAutoHideTaskbarThicknessPx = 2; -const int kAutoHideTaskbarThicknessPy = kAutoHideTaskbarThicknessPx; - -const UINT m_defaultDotsPerInch = USER_DEFAULT_SCREEN_DPI; - -const qreal m_defaultDevicePixelRatio = 1.0; - -int m_borderWidth = -1, m_borderHeight = -1, m_titlebarHeight = -1; - -QScopedPointer m_instance; - -QVector m_framelessWindows; - -} // namespace - -WinNativeEventFilter::WinNativeEventFilter() { initWin32Api(); } - -WinNativeEventFilter::~WinNativeEventFilter() = default; - -void WinNativeEventFilter::install() { - if (m_instance.isNull()) { - m_instance.reset(new WinNativeEventFilter); - qApp->installNativeEventFilter(m_instance.data()); - } -} - -void WinNativeEventFilter::uninstall() { - if (!m_instance.isNull()) { - qApp->removeNativeEventFilter(m_instance.data()); - m_instance.reset(); - } - if (!m_framelessWindows.isEmpty()) { - m_framelessWindows.clear(); - } -} - -QVector WinNativeEventFilter::framelessWindows() { - return m_framelessWindows; -} - -void WinNativeEventFilter::setFramelessWindows(QVector windows) { - if (!windows.isEmpty() && (windows != m_framelessWindows)) { - m_framelessWindows = windows; - install(); - } -} - -void WinNativeEventFilter::addFramelessWindow(HWND window, - const WINDOWDATA *data) { - initWin32Api(); - if (window && m_lpIsWindow(window) && - !m_framelessWindows.contains(window)) { - m_framelessWindows.append(window); - if (data) { - createUserData(window, data); - } - install(); - } -} - -void WinNativeEventFilter::removeFramelessWindow(HWND window) { - if (window && m_framelessWindows.contains(window)) { - m_framelessWindows.removeAll(window); - } -} - -void WinNativeEventFilter::clearFramelessWindows() { - if (!m_framelessWindows.isEmpty()) { - m_framelessWindows.clear(); - } -} - -#if (QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)) -bool WinNativeEventFilter::nativeEventFilter(const QByteArray &eventType, - void *message, qintptr *result) -#else -bool WinNativeEventFilter::nativeEventFilter(const QByteArray &eventType, - void *message, long *result) -#endif -{ - Q_UNUSED(eventType) - const auto msg = static_cast(message); - if (!msg->hwnd) { - // Why sometimes the window handle is null? Is it designed to be? - // Anyway, we should skip it in this case. - return false; - } - if (!m_lpIsWindow(msg->hwnd)) { - return false; - } - if (m_framelessWindows.isEmpty()) { - // Only top level windows can be frameless. - if (!IsWindowTopLevel(msg->hwnd)) { - return false; - } - } else if (!m_framelessWindows.contains(msg->hwnd)) { - return false; - } - createUserData(msg->hwnd); - const auto data = reinterpret_cast( - m_lpGetWindowLongPtrW(msg->hwnd, GWLP_USERDATA)); - if (!data->initialized) { - // Avoid initializing a same window twice. - data->initialized = TRUE; - // Restore default window style. - m_lpSetWindowLongPtrW(msg->hwnd, GWL_STYLE, - WS_OVERLAPPEDWINDOW | WS_CLIPCHILDREN | - WS_CLIPSIBLINGS); - // The following two lines can help us get rid of the three system - // buttons (minimize, maximize and close). But they also break the - // Arcylic effect (introduced in Win10 1709), don't know why. - m_lpSetWindowLongPtrW(msg->hwnd, GWL_EXSTYLE, - WS_EX_APPWINDOW | WS_EX_LAYERED); - m_lpSetLayeredWindowAttributes(msg->hwnd, RGB(255, 0, 255), 0, - LWA_COLORKEY); - updateWindow(msg->hwnd, true, false); - // Make sure our window have it's frame shadow. - // The frame shadow is drawn by Desktop Window Manager (DWM), don't draw - // it yourself. The frame shadow will get lost if DWM composition is - // disabled, it's designed to be, don't force the window to draw a frame - // shadow in that case. - updateGlass(msg->hwnd); -#ifdef _DEBUG - // For debug purposes. - qDebug().noquote() << "Window handle:" << msg->hwnd; - qDebug().noquote() << "Window DPI:" - << getDotsPerInchForWindow(msg->hwnd) - << "Window DPR:" - << getDevicePixelRatioForWindow(msg->hwnd); - qDebug().noquote() - << "Window border width:" - << getSystemMetric(msg->hwnd, SystemMetric::BorderWidth, false) - << "Window border height:" - << getSystemMetric(msg->hwnd, SystemMetric::BorderHeight, false) - << "Window titlebar height:" - << getSystemMetric(msg->hwnd, SystemMetric::TitleBarHeight, false); -#endif - } - switch (msg->message) { - case WM_NCCALCSIZE: { - // Windows是根据这个消息的返回值来设置窗口的客户区（窗口中真正显示的内容） - // 和非客户区（标题栏、窗口边框、菜单栏和状态栏等Windows系统自行提供的部分 - // ，不过对于Qt来说，除了标题栏和窗口边框，非客户区基本也都是自绘的）的范 - // 围的，lParam里存放的就是新客户区的几何区域，默认是整个窗口的大小，正常 - // 的程序需要修改这个参数，告知系统窗口的客户区和非客户区的范围（一般来说可 - // 以完全交给Windows，让其自行处理，使用默认的客户区和非客户区），因此如果 - // 我们不修改lParam，就可以使客户区充满整个窗口，从而去掉标题栏和窗口边框 - // （因为这些东西都被客户区给盖住了。但边框阴影也会因此而丢失，不过我们会使 - // 用其他方式将其带回，请参考其他消息的处理，此处不过多提及）。但有个情况要 - // 特别注意，那就是窗口最大化后，窗口的实际尺寸会比屏幕的尺寸大一点，从而使 - // 用户看不到窗口的边界，这样用户就不能在窗口最大化后调整窗口的大小了（虽然 - // 这个做法听起来特别奇怪，但Windows确实就是这样做的），因此如果我们要自行 - // 处理窗口的非客户区，就要在窗口最大化后，将窗口边框的宽度和高度（一般是相 - // 等的）从客户区裁剪掉，否则我们窗口所显示的内容就会超出屏幕边界，显示不全。 - // 如果用户开启了任务栏自动隐藏，在窗口最大化后，还要考虑任务栏的位置。因为 - // 如果窗口最大化后，其尺寸和屏幕尺寸相等（因为任务栏隐藏了，所以窗口最大化 - // 后其实是充满了整个屏幕，变相的全屏了），Windows会认为窗口已经进入全屏的 - // 状态，从而导致自动隐藏的任务栏无法弹出。要避免这个状况，就要使窗口的尺寸 - // 小于屏幕尺寸。我下面的做法，参考了火狐和Chromium。但是如果没有开启任务 - // 栏自动隐藏，是不存在这个问题的，所以要先进行判断。 - // 一般情况下，*result设置为0（相当于DefWindowProc的返回值为0）就可以了， - // 根据MSDN的说法，返回0意为此消息已经被程序自行处理了，让Windows跳过此消 - // 息，否则Windows会添加对此消息的默认处理，对于当前这个消息而言，就意味着 - // 标题栏和窗口边框又会回来，这当然不是我们想要的结果。根据MSDN，当wParam - // 为FALSE时，只能返回0，但当其为TRUE时，可以返回0，也可以返回一个WVR_常 - // 量。根据Chromium的注释，当存在非客户区时，如果返回WVR_REDRAW会导致子 - // 窗口/子控件出现奇怪的bug（自绘控件错位），并且Lucas在Windows 10上成 - // 功复现，说明这个bug至今都没有解决。因为这个是Windows自身的bug，且已经 - // 存在很久，这种情况下只有返回0才能规避这个问题。但如果不存在非客户区，且 - // wParam为TRUE，最好返回WVR_REDRAW，否则窗口在调整大小可能会产生严重的 - // 闪烁现象。 - // 虽然对大多数消息来说，返回0都代表让Windows忽略此消息，但实际上不同消息 - // 能接受的返回值是不一样的，请注意自行查阅MSDN。 - - // Sent when the size and position of a window's client area must be - // calculated. By processing this message, an application can control - // the content of the window's client area when the size or position of - // the window changes. If wParam is TRUE, lParam points to an - // NCCALCSIZE_PARAMS structure that contains information an application - // can use to calculate the new size and position of the client - // rectangle. If wParam is FALSE, lParam points to a RECT structure. On - // entry, the structure contains the proposed window rectangle for the - // window. On exit, the structure should contain the screen coordinates - // of the corresponding window client area. - const auto getClientAreaInsets = [](HWND _hWnd) -> RECT { - // We don't need this correction when we're fullscreen. We will have - // the WS_POPUP size, so we don't have to worry about borders, and - // the default frame will be fine. - if (IsMaximized(_hWnd) && !IsFullScreened(_hWnd)) { - // Windows automatically adds a standard width border to all - // sides when a window is maximized. - int frameThickness_x = - getSystemMetric(_hWnd, SystemMetric::BorderWidth); - int frameThickness_y = - getSystemMetric(_hWnd, SystemMetric::BorderHeight); - // The following two lines are two seperate functions in - // Chromium, it uses them to judge whether the window - // should draw it's own frame or not. But here we will always - // draw our own frame because our window is totally frameless, - // so we can simply use constants here. I don't remove them - // completely because I don't want to forget what it's about to - // achieve. - const bool removeStandardFrame = true; - const bool hasFrame = !removeStandardFrame; - if (!hasFrame) { - frameThickness_x -= 1; - frameThickness_y -= 1; - } - RECT rect; - rect.top = frameThickness_y; - rect.bottom = frameThickness_y; - rect.left = frameThickness_x; - rect.right = frameThickness_x; - return rect; - } - return {0, 0, 0, 0}; - }; - const RECT insets = getClientAreaInsets(msg->hwnd); - const auto mode = static_cast(msg->wParam); - // If the window bounds change, we're going to relayout and repaint - // anyway. Returning WVR_REDRAW avoids an extra paint before that of the - // old client pixels in the (now wrong) location, and thus makes actions - // like resizing a window from the left edge look slightly less broken. - *result = mode ? WVR_REDRAW : 0; - const auto clientRect = mode - ? &(reinterpret_cast(msg->lParam)->rgrc[0]) - : reinterpret_cast(msg->lParam); - clientRect->top += insets.top; - clientRect->bottom -= insets.bottom; - clientRect->left += insets.left; - clientRect->right -= insets.right; - if (IsMaximized(msg->hwnd)) { - APPBARDATA abd; - SecureZeroMemory(&abd, sizeof(abd)); - abd.cbSize = sizeof(abd); - const UINT taskbarState = m_lpSHAppBarMessage(ABM_GETSTATE, &abd); - if (taskbarState & ABS_AUTOHIDE) { - const HMONITOR windowMonitor = - m_lpMonitorFromWindow(msg->hwnd, MONITOR_DEFAULTTONEAREST); - bool top = false, bottom = false, left = false, right = false; - if (QOperatingSystemVersion::current() >= - QOperatingSystemVersion::Windows8_1) { - MONITORINFO monitorInfo; - SecureZeroMemory(&monitorInfo, sizeof(monitorInfo)); - monitorInfo.cbSize = sizeof(monitorInfo); - m_lpGetMonitorInfoW(windowMonitor, &monitorInfo); - const auto hasAutohideTaskbar = - [&monitorInfo](const UINT edge) -> bool { - APPBARDATA _abd; - SecureZeroMemory(&_abd, sizeof(_abd)); - _abd.cbSize = sizeof(_abd); - _abd.uEdge = edge; - _abd.rc = monitorInfo.rcMonitor; - const auto hTaskbar = reinterpret_cast( - m_lpSHAppBarMessage(ABM_GETAUTOHIDEBAREX, &_abd)); - return hTaskbar != nullptr; - }; - top = hasAutohideTaskbar(ABE_TOP); - bottom = hasAutohideTaskbar(ABE_BOTTOM); - left = hasAutohideTaskbar(ABE_LEFT); - right = hasAutohideTaskbar(ABE_RIGHT); - } else { - int edge = -1; - APPBARDATA _abd; - SecureZeroMemory(&_abd, sizeof(_abd)); - _abd.cbSize = sizeof(_abd); - _abd.hWnd = m_lpFindWindowW(L"Shell_TrayWnd", nullptr); - if (_abd.hWnd) { - const HMONITOR taskbarMonitor = m_lpMonitorFromWindow( - _abd.hWnd, MONITOR_DEFAULTTOPRIMARY); - if (taskbarMonitor == windowMonitor) { - m_lpSHAppBarMessage(ABM_GETTASKBARPOS, &_abd); - edge = _abd.uEdge; - } - } - top = edge == ABE_TOP; - bottom = edge == ABE_BOTTOM; - left = edge == ABE_LEFT; - right = edge == ABE_RIGHT; - } - if (top) { - clientRect->top += kAutoHideTaskbarThicknessPy; - } else if (bottom) { - clientRect->bottom -= kAutoHideTaskbarThicknessPy; - } else if (left) { - clientRect->left += kAutoHideTaskbarThicknessPx; - } else if (right) { - clientRect->right -= kAutoHideTaskbarThicknessPx; - } - } - // We cannot return WVR_REDRAW when there is nonclient area, or - // Windows exhibits bugs where client pixels and child HWNDs are - // mispositioned by the width/height of the upper-left nonclient - // area. - *result = 0; - } - return true; - } - case WM_NCUAHDRAWCAPTION: - case WM_NCUAHDRAWFRAME: { - // These undocumented messages are sent to draw themed window - // borders. Block them to prevent drawing borders over the client - // area. - *result = 0; - return true; - } - case WM_NCPAINT: { - // 边框阴影处于非客户区的范围，因此如果直接阻止非客户区的绘制，会导致边框阴影丢失 - - if (IsDwmCompositionEnabled()) { - break; - } else { - // Only block WM_NCPAINT when DWM composition is disabled. If it's - // blocked when DWM composition is enabled, the frame shadow won't - // be drawn. - *result = 0; - return true; - } - } - case WM_NCACTIVATE: { - // DefWindowProc won't repaint the window border if lParam (normally - // a HRGN) is -1. - // Don't use "*result = 0" otherwise the window won't respond to - // the window active state change. - *result = m_lpDefWindowProcW(msg->hwnd, msg->message, msg->wParam, -1); - return true; - } - case WM_NCHITTEST: { - // 测试了一下原生Win32窗口，发现只有顶边是在窗口内部resize的，其余三边 - // 都是在窗口外部进行resize的，但WM_NCHITTEST这个消息只有在鼠标进入窗 - // 口的范围内才会被触发，因此没法在这个消息里实现窗口外部的resize。火狐 - // 和Chromium是怎么做到的？Hook鼠标事件？ - - if (data->windowData.mouseTransparent) { - // Mouse events will be passed to the parent window. - *result = HTTRANSPARENT; - return true; - } - const auto getHTResult = [](HWND _hWnd, LPARAM _lParam, - const WINDOW *_data) -> LRESULT { - const auto isInSpecificAreas = [](int x, int y, - const QVector &areas, - qreal dpr) -> bool { - for (auto &&area : std::as_const(areas)) { - if (!area.isValid()) { - continue; - } - if (QRect(std::round(area.x() * dpr), - std::round(area.y() * dpr), - std::round(area.width() * dpr), - std::round(area.height() * dpr)) - .contains(x, y, true)) { - return true; - } - } - return false; - }; - RECT clientRect = {0, 0, 0, 0}; - m_lpGetClientRect(_hWnd, &clientRect); - const LONG ww = clientRect.right; - const LONG wh = clientRect.bottom; - POINT mouse; - // Don't use HIWORD(lParam) and LOWORD(lParam) to get cursor - // coordinates because their results are unsigned numbers, however - // the cursor position may be negative due to in a different - // monitor. - mouse.x = GET_X_LPARAM(_lParam); - mouse.y = GET_Y_LPARAM(_lParam); - m_lpScreenToClient(_hWnd, &mouse); - // These values are DPI-aware. - const LONG bw = getSystemMetric(_hWnd, SystemMetric::BorderWidth); - const LONG bh = getSystemMetric(_hWnd, SystemMetric::BorderHeight); - const LONG tbh = - getSystemMetric(_hWnd, SystemMetric::TitleBarHeight); - const qreal dpr = getDevicePixelRatioForWindow(_hWnd); - const bool isTitlebar = (mouse.y < tbh) && - !isInSpecificAreas(mouse.x, mouse.y, - _data->windowData.ignoreAreas, dpr) && - (_data->windowData.draggableAreas.isEmpty() - ? true - : isInSpecificAreas(mouse.x, mouse.y, - _data->windowData.draggableAreas, - dpr)); - if (IsMaximized(_hWnd)) { - if (isTitlebar) { - return HTCAPTION; - } - return HTCLIENT; - } - const bool isTop = mouse.y < bh; - const bool isBottom = mouse.y > (wh - bh); - // Make the border wider to let the user easy to resize on corners. - const int factor = (isTop || isBottom) ? 2 : 1; - const bool isLeft = mouse.x < (bw * factor); - const bool isRight = mouse.x > (ww - (bw * factor)); - const bool fixedSize = _data->windowData.fixedSize; - const auto getBorderValue = [fixedSize](int value) -> int { - // HTBORDER: non-resizeable window border. - return fixedSize ? HTBORDER : value; - }; - if (isTop) { - if (isLeft) { - return getBorderValue(HTTOPLEFT); - } - if (isRight) { - return getBorderValue(HTTOPRIGHT); - } - return getBorderValue(HTTOP); - } - if (isBottom) { - if (isLeft) { - return getBorderValue(HTBOTTOMLEFT); - } - if (isRight) { - return getBorderValue(HTBOTTOMRIGHT); - } - return getBorderValue(HTBOTTOM); - } - if (isLeft) { - return getBorderValue(HTLEFT); - } - if (isRight) { - return getBorderValue(HTRIGHT); - } - if (isTitlebar) { - return HTCAPTION; - } - return HTCLIENT; - }; - *result = getHTResult(msg->hwnd, msg->lParam, data); - return true; - } - case WM_GETMINMAXINFO: { - // Don't cover the taskbar when maximized. - const HMONITOR monitor = - m_lpMonitorFromWindow(msg->hwnd, MONITOR_DEFAULTTONEAREST); - MONITORINFO monitorInfo; - SecureZeroMemory(&monitorInfo, sizeof(monitorInfo)); - monitorInfo.cbSize = sizeof(monitorInfo); - m_lpGetMonitorInfoW(monitor, &monitorInfo); - const RECT rcWorkArea = monitorInfo.rcWork; - const RECT rcMonitorArea = monitorInfo.rcMonitor; - auto &mmi = *reinterpret_cast(msg->lParam); - if (QOperatingSystemVersion::current() < - QOperatingSystemVersion::Windows8) { - // FIXME: Buggy on Windows 7: - // The origin of coordinates is the top left edge of the - // monitor's work area. Why? It should be the top left edge of - // the monitor's area. - mmi.ptMaxPosition.x = rcMonitorArea.left; - mmi.ptMaxPosition.y = rcMonitorArea.top; - } else { - // Works fine on Windows 8/8.1/10 - mmi.ptMaxPosition.x = - std::abs(rcWorkArea.left - rcMonitorArea.left); - mmi.ptMaxPosition.y = std::abs(rcWorkArea.top - rcMonitorArea.top); - } - if (data->windowData.maximumSize.isEmpty()) { - mmi.ptMaxSize.x = std::abs(rcWorkArea.right - rcWorkArea.left); - mmi.ptMaxSize.y = std::abs(rcWorkArea.bottom - rcWorkArea.top); - } else { - mmi.ptMaxSize.x = - std::round(getDevicePixelRatioForWindow(msg->hwnd) * - data->windowData.maximumSize.width()); - mmi.ptMaxSize.y = - std::round(getDevicePixelRatioForWindow(msg->hwnd) * - data->windowData.maximumSize.height()); - } - mmi.ptMaxTrackSize.x = mmi.ptMaxSize.x; - mmi.ptMaxTrackSize.y = mmi.ptMaxSize.y; - if (!data->windowData.minimumSize.isEmpty()) { - mmi.ptMinTrackSize.x = - std::round(getDevicePixelRatioForWindow(msg->hwnd) * - data->windowData.minimumSize.width()); - mmi.ptMinTrackSize.y = - std::round(getDevicePixelRatioForWindow(msg->hwnd) * - data->windowData.minimumSize.height()); - } - *result = 0; - return true; - } - case WM_SETICON: - case WM_SETTEXT: { - // Disable painting while these messages are handled to prevent them - // from drawing a window caption over the client area. - const auto oldStyle = m_lpGetWindowLongPtrW(msg->hwnd, GWL_STYLE); - // Prevent Windows from drawing the default title bar by temporarily - // toggling the WS_VISIBLE style. - m_lpSetWindowLongPtrW(msg->hwnd, GWL_STYLE, oldStyle & ~WS_VISIBLE); - updateWindow(msg->hwnd, true, false); - const LRESULT ret = m_lpDefWindowProcW(msg->hwnd, msg->message, - msg->wParam, msg->lParam); - m_lpSetWindowLongPtrW(msg->hwnd, GWL_STYLE, oldStyle); - updateWindow(msg->hwnd, true, false); - *result = ret; - return true; - } - case WM_DWMCOMPOSITIONCHANGED: { - updateGlass(msg->hwnd); - break; - } - default: { - break; - } - } - return false; -} - -void WinNativeEventFilter::updateGlass(HWND handle) { - MARGINS margins = {0, 0, 0, 0}; - if (IsDwmCompositionEnabled()) { - // The frame shadow is drawn on the non-client area and thus we have - // to make sure the non-client area rendering is enabled first. - const DWMNCRENDERINGPOLICY ncrp = DWMNCRP_ENABLED; - m_lpDwmSetWindowAttribute(handle, DWMWA_NCRENDERING_POLICY, &ncrp, - sizeof(ncrp)); - // Negative margins have special meaning to - // DwmExtendFrameIntoClientArea. Negative margins create the "sheet of - // glass" effect, where the client area is rendered as a solid surface - // with no window border. - // Use positive margins have similar appearance, but the window - // background will be transparent, we don't want that. - margins = {-1, -1, -1, -1}; - } - m_lpDwmExtendFrameIntoClientArea(handle, &margins); -} - -UINT WinNativeEventFilter::getDotsPerInchForWindow(HWND handle) { +UINT GetDotsPerInchForWindow(HWND handle) { const auto getScreenDpi = [](UINT defaultValue) -> UINT { if (m_lpD2D1CreateFactory) { // Using Direct2D to get the screen DPI. @@ -852,7 +481,7 @@ UINT WinNativeEventFilter::getDotsPerInchForWindow(HWND handle) { // Return hard-coded DPI if DPI scaling is disabled. return m_defaultDotsPerInch; } - if (!handle) { + if (!handle || !m_lpIsWindow(handle)) { if (m_lpGetSystemDpiForProcess) { return m_lpGetSystemDpiForProcess(m_lpGetCurrentProcess()); } else if (m_lpGetDpiForSystem) { @@ -874,165 +503,7 @@ UINT WinNativeEventFilter::getDotsPerInchForWindow(HWND handle) { return getScreenDpi(m_defaultDotsPerInch); } -qreal WinNativeEventFilter::getDevicePixelRatioForWindow(HWND handle) { - const qreal dpr = handle - ? (static_cast(getDotsPerInchForWindow(handle)) / - static_cast(m_defaultDotsPerInch)) - : m_defaultDevicePixelRatio; - return getPreferedNumber(dpr); -} - -int WinNativeEventFilter::getSystemMetricsForWindow(HWND handle, int index) { - if (m_lpGetSystemMetricsForDpi) { - return m_lpGetSystemMetricsForDpi( - index, - static_cast(std::round( - getPreferedNumber(getDotsPerInchForWindow(handle))))); - } else { - return std::round(m_lpGetSystemMetrics(index) * - getDevicePixelRatioForWindow(handle)); - } -} - -void WinNativeEventFilter::setWindowData(HWND window, const WINDOWDATA *data) { - initWin32Api(); - if (window && m_lpIsWindow(window) && data) { - createUserData(window, data); - } -} - -WinNativeEventFilter::WINDOWDATA * -WinNativeEventFilter::windowData(HWND window) { - initWin32Api(); - if (window && m_lpIsWindow(window)) { - createUserData(window); - return &reinterpret_cast( - m_lpGetWindowLongPtrW(window, GWLP_USERDATA)) - ->windowData; - } - return nullptr; -} - -void WinNativeEventFilter::createUserData(HWND handle, const WINDOWDATA *data) { - if (handle) { - const auto userData = reinterpret_cast( - m_lpGetWindowLongPtrW(handle, GWLP_USERDATA)); - if (userData) { - if (data) { - userData->windowData = *data; - } - } else { - WINDOW *_data = new WINDOW; - _data->hWnd = handle; - if (data) { - _data->windowData = *data; - } - m_lpSetWindowLongPtrW(handle, GWLP_USERDATA, - reinterpret_cast(_data)); - updateWindow(handle, true, false); - } - } -} - -void WinNativeEventFilter::initWin32Api() { - static bool resolved = false; - if (resolved) { - return; - } - resolved = true; - // Available since Windows 2000. - WNEF_RESOLVE_WINAPI(User32, EndPaint) - WNEF_RESOLVE_WINAPI(User32, BeginPaint) - WNEF_RESOLVE_WINAPI(User32, FillRect) - WNEF_RESOLVE_WINAPI(User32, GetWindowInfo) - WNEF_RESOLVE_WINAPI(User32, IsWindow) - WNEF_RESOLVE_WINAPI(User32, SetWindowRgn) - WNEF_RESOLVE_WINAPI(User32, InvalidateRect) - WNEF_RESOLVE_WINAPI(User32, UpdateWindow) - WNEF_RESOLVE_WINAPI(User32, SetWindowPos) - WNEF_RESOLVE_WINAPI(User32, SendMessageW) - WNEF_RESOLVE_WINAPI(User32, GetDesktopWindow) - WNEF_RESOLVE_WINAPI(User32, GetAncestor) - WNEF_RESOLVE_WINAPI(User32, DefWindowProcW) - WNEF_RESOLVE_WINAPI(User32, SetLayeredWindowAttributes) - WNEF_RESOLVE_WINAPI(User32, MoveWindow) - WNEF_RESOLVE_WINAPI(User32, IsZoomed) - WNEF_RESOLVE_WINAPI(User32, IsIconic) - WNEF_RESOLVE_WINAPI(User32, GetSystemMetrics) - WNEF_RESOLVE_WINAPI(User32, GetDC) - WNEF_RESOLVE_WINAPI(User32, ReleaseDC) - WNEF_RESOLVE_WINAPI(User32, RedrawWindow) - WNEF_RESOLVE_WINAPI(User32, GetClientRect) - WNEF_RESOLVE_WINAPI(User32, GetWindowRect) - WNEF_RESOLVE_WINAPI(User32, ScreenToClient) - WNEF_RESOLVE_WINAPI(User32, EqualRect) -#ifdef Q_PROCESSOR_X86_64 - WNEF_RESOLVE_WINAPI(User32, GetWindowLongPtrW) - WNEF_RESOLVE_WINAPI(User32, SetWindowLongPtrW) - WNEF_RESOLVE_WINAPI(User32, SetClassLongPtrW) -#else - WNEF_RESOLVE_WINAPI(User32, GetWindowLongW) - WNEF_RESOLVE_WINAPI(User32, SetWindowLongW) - WNEF_RESOLVE_WINAPI(User32, SetClassLongW) -#endif - WNEF_RESOLVE_WINAPI(User32, FindWindowW) - WNEF_RESOLVE_WINAPI(User32, MonitorFromWindow) - WNEF_RESOLVE_WINAPI(User32, GetMonitorInfoW) - WNEF_RESOLVE_WINAPI(Gdi32, GetDeviceCaps) - WNEF_RESOLVE_WINAPI(Gdi32, CreateSolidBrush) - WNEF_RESOLVE_WINAPI(Gdi32, DeleteObject) - // Available since Windows XP. - WNEF_RESOLVE_WINAPI(Shell32, SHAppBarMessage) - WNEF_RESOLVE_WINAPI(Kernel32, GetCurrentProcess) - // Available since Windows Vista. - WNEF_RESOLVE_WINAPI(User32, IsProcessDPIAware) - WNEF_RESOLVE_WINAPI(Dwmapi, DwmIsCompositionEnabled) - WNEF_RESOLVE_WINAPI(Dwmapi, DwmExtendFrameIntoClientArea) - WNEF_RESOLVE_WINAPI(Dwmapi, DwmSetWindowAttribute) - WNEF_RESOLVE_WINAPI(UxTheme, IsThemeActive) - // Available since Windows 7. - WNEF_RESOLVE_WINAPI(D2D1, D2D1CreateFactory) - // Available since Windows 8.1 - if (QOperatingSystemVersion::current() >= - QOperatingSystemVersion::Windows8_1) { - WNEF_RESOLVE_WINAPI(SHCore, GetDpiForMonitor) - WNEF_RESOLVE_WINAPI(SHCore, GetProcessDpiAwareness) - } - // Available since Windows 10, version 1607 (10.0.14393) - if (QOperatingSystemVersion::current() >= - QOperatingSystemVersion(QOperatingSystemVersion::Windows, 10, 0, - 14393)) { - WNEF_RESOLVE_WINAPI(User32, GetDpiForWindow) - WNEF_RESOLVE_WINAPI(User32, GetDpiForSystem) - WNEF_RESOLVE_WINAPI(User32, GetSystemMetricsForDpi) - } - // Available since Windows 10, version 1803 (10.0.17134) - if (QOperatingSystemVersion::current() >= - QOperatingSystemVersion(QOperatingSystemVersion::Windows, 10, 0, - 17134)) { - WNEF_RESOLVE_WINAPI(User32, GetSystemDpiForProcess) - } -} - -void WinNativeEventFilter::setBorderWidth(int bw) { - if (m_borderWidth != bw) { - m_borderWidth = bw; - } -} - -void WinNativeEventFilter::setBorderHeight(int bh) { - if (m_borderHeight != bh) { - m_borderHeight = bh; - } -} - -void WinNativeEventFilter::setTitlebarHeight(int tbh) { - if (m_titlebarHeight != tbh) { - m_titlebarHeight = tbh; - } -} - -qreal WinNativeEventFilter::getPreferedNumber(qreal num) { +qreal GetPreferedNumber(qreal num) { qreal result = -1.0; const auto getRoundedNumber = [](qreal in) -> qreal { // If the given number is not very large, we assume it's a @@ -1085,9 +556,569 @@ qreal WinNativeEventFilter::getPreferedNumber(qreal num) { return result; } +qreal GetDevicePixelRatioForWindow(HWND handle) { + qreal result = m_defaultDevicePixelRatio; + if (handle && m_lpIsWindow(handle)) { + result = static_cast(GetDotsPerInchForWindow(handle)) / + static_cast(m_defaultDotsPerInch); + } + return GetPreferedNumber(result); +} + +RECT GetFrameSizeForWindow(HWND handle, bool includingTitleBar = false) { + RECT rect = {0, 0, 0, 0}; + if (handle && m_lpIsWindow(handle)) { + const auto style = m_lpGetWindowLongPtrW(handle, GWL_STYLE); + if (m_lpAdjustWindowRectExForDpi) { + m_lpAdjustWindowRectExForDpi( + &rect, + includingTitleBar ? (style | WS_CAPTION) + : (style & ~WS_CAPTION), + FALSE, m_lpGetWindowLongPtrW(handle, GWL_EXSTYLE), + GetDotsPerInchForWindow(handle)); + } else { + m_lpAdjustWindowRectEx(&rect, + includingTitleBar ? (style | WS_CAPTION) + : (style & ~WS_CAPTION), + FALSE, + m_lpGetWindowLongPtrW(handle, GWL_EXSTYLE)); + const qreal dpr = GetDevicePixelRatioForWindow(handle); + rect.top = std::round(rect.top * dpr); + rect.bottom = std::round(rect.bottom * dpr); + rect.left = std::round(rect.left * dpr); + rect.right = std::round(rect.right * dpr); + } + // These are negative values. Make them positive. + rect.top = -rect.top; + rect.left = -rect.left; + } + return rect; +} + +void UpdateFrameMarginsForWindow(HWND handle) { + if (handle && m_lpIsWindow(handle)) { + // We removed the whole top part of the frame (see handling of + // WM_NCCALCSIZE) so the top border is missing now. We add it back here. + // Note #1: You might wonder why we don't remove just the title bar + // instead of removing the whole top part of the frame and then adding + // the little top border back. I tried to do this but it didn't work: + // DWM drew the whole title bar anyways on top of the window. It seems + // that DWM only wants to draw either nothing or the whole top part of + // the frame. + // Note #2: For some reason if you try to set the top margin to just + // the top border height (what we want to do), then there is a + // transparency bug when the window is inactive, so I've decided to add + // the whole top part of the frame instead and then we will hide + // everything that we don't need (that is, the whole thing but the + // little 1 pixel wide border at the top) in the WM_PAINT handler. + // This eliminates the transparency bug and it's what a lot of Win32 + // apps that customize the title bar do so it should work fine. + const MARGINS margins = {0, 0, GetFrameSizeForWindow(handle).top, 0}; + m_lpDwmExtendFrameIntoClientArea(handle, &margins); + } +} + +int GetSystemMetricsForWindow(HWND handle, int index) { + if (handle && m_lpIsWindow(handle)) { + if (m_lpGetSystemMetricsForDpi) { + return m_lpGetSystemMetricsForDpi( + index, + static_cast(std::round( + GetPreferedNumber(GetDotsPerInchForWindow(handle))))); + } else { + return std::round(m_lpGetSystemMetrics(index) * + GetDevicePixelRatioForWindow(handle)); + } + } + return -1; +} + +void createUserData(HWND handle, + const WinNativeEventFilter::WINDOWDATA *data = nullptr) { + if (handle && m_lpIsWindow(handle)) { + const auto userData = reinterpret_cast( + m_lpGetWindowLongPtrW(handle, GWLP_USERDATA)); + if (userData) { + if (data) { + userData->windowData = *data; + } + } else { + WinNativeEventFilter::WINDOW *_data = + new WinNativeEventFilter::WINDOW; + _data->hWnd = handle; + if (data) { + _data->windowData = *data; + } + m_lpSetWindowLongPtrW(handle, GWLP_USERDATA, + reinterpret_cast(_data)); + WinNativeEventFilter::updateWindow(handle, true, false); + } + } +} + +// The thickness of an auto-hide taskbar in pixels. +const int kAutoHideTaskbarThicknessPx = 2; +const int kAutoHideTaskbarThicknessPy = kAutoHideTaskbarThicknessPx; + +QScopedPointer m_instance; + +QVector m_framelessWindows; + +} // namespace + +WinNativeEventFilter::WinNativeEventFilter() { ResolveWin32APIs(); } + +WinNativeEventFilter::~WinNativeEventFilter() = default; + +void WinNativeEventFilter::install() { + if (m_instance.isNull()) { + m_instance.reset(new WinNativeEventFilter); + qApp->installNativeEventFilter(m_instance.data()); + } +} + +void WinNativeEventFilter::uninstall() { + if (!m_instance.isNull()) { + qApp->removeNativeEventFilter(m_instance.data()); + m_instance.reset(); + } + if (!m_framelessWindows.isEmpty()) { + m_framelessWindows.clear(); + } +} + +QVector WinNativeEventFilter::framelessWindows() { + return m_framelessWindows; +} + +void WinNativeEventFilter::setFramelessWindows(QVector windows) { + if (!windows.isEmpty() && (windows != m_framelessWindows)) { + m_framelessWindows = windows; + install(); + } +} + +void WinNativeEventFilter::addFramelessWindow(HWND window, + const WINDOWDATA *data) { + ResolveWin32APIs(); + if (window && m_lpIsWindow(window) && + !m_framelessWindows.contains(window)) { + m_framelessWindows.append(window); + if (data) { + createUserData(window, data); + } + install(); + } +} + +void WinNativeEventFilter::removeFramelessWindow(HWND window) { + if (window && m_framelessWindows.contains(window)) { + m_framelessWindows.removeAll(window); + } +} + +void WinNativeEventFilter::clearFramelessWindows() { + if (!m_framelessWindows.isEmpty()) { + m_framelessWindows.clear(); + } +} + +#if (QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)) +bool WinNativeEventFilter::nativeEventFilter(const QByteArray &eventType, + void *message, qintptr *result) +#else +bool WinNativeEventFilter::nativeEventFilter(const QByteArray &eventType, + void *message, long *result) +#endif +{ + // The example code in Qt's documentation has this check. + if (eventType == "windows_generic_MSG") { +#if (QT_VERSION == QT_VERSION_CHECK(5, 11, 1)) + // Work-around a bug caused by typo which only exists in Qt 5.11.1 + const auto msg = *reinterpret_cast(message); +#else + const auto msg = static_cast(message); +#endif + if (!msg || (msg && !msg->hwnd)) { + // Why sometimes the window handle is null? Is it designed to be? + // Anyway, we should skip it in this case. + return false; + } + if (m_framelessWindows.isEmpty()) { + // Only top level windows can be frameless. + if (!IsTopLevel(msg->hwnd)) { + return false; + } + } else if (!m_framelessWindows.contains(msg->hwnd)) { + return false; + } + createUserData(msg->hwnd); + const auto data = reinterpret_cast( + m_lpGetWindowLongPtrW(msg->hwnd, GWLP_USERDATA)); + if (!data->initialized) { + // Avoid initializing a same window twice. + data->initialized = TRUE; + // Trigger a frame change event to let us enter the WM_NCCALCSIZE + // message to remove our title bar as early as possible. + updateWindow(msg->hwnd, true, false); + } + LRESULT dwmHitResult = 0; + if (!data->windowData.mouseTransparent && IsDwmCompositionEnabled() && + m_lpDwmDefWindowProc && + m_lpDwmDefWindowProc(msg->hwnd, msg->message, msg->wParam, + msg->lParam, &dwmHitResult)) { + *result = dwmHitResult; + return true; + } + switch (msg->message) { + case WM_NCCALCSIZE: { + // Windows是根据这个消息的返回值来设置窗口的客户区（窗口中真正显示的内容） + // 和非客户区（标题栏、窗口边框、菜单栏和状态栏等Windows系统自行提供的部分 + // ，不过对于Qt来说，除了标题栏和窗口边框，非客户区基本也都是自绘的）的范 + // 围的，lParam里存放的就是新客户区的几何区域，默认是整个窗口的大小，正常 + // 的程序需要修改这个参数，告知系统窗口的客户区和非客户区的范围（一般来说可 + // 以完全交给Windows，让其自行处理，使用默认的客户区和非客户区），因此如果 + // 我们不修改lParam，就可以使客户区充满整个窗口，从而去掉标题栏和窗口边框 + // （因为这些东西都被客户区给盖住了。但边框阴影也会因此而丢失，不过我们会使 + // 用其他方式将其带回，请参考其他消息的处理，此处不过多提及）。但有个情况要 + // 特别注意，那就是窗口最大化后，窗口的实际尺寸会比屏幕的尺寸大一点，从而使 + // 用户看不到窗口的边界，这样用户就不能在窗口最大化后调整窗口的大小了（虽然 + // 这个做法听起来特别奇怪，但Windows确实就是这样做的），因此如果我们要自行 + // 处理窗口的非客户区，就要在窗口最大化后，将窗口边框的宽度和高度（一般是相 + // 等的）从客户区裁剪掉，否则我们窗口所显示的内容就会超出屏幕边界，显示不全。 + // 如果用户开启了任务栏自动隐藏，在窗口最大化后，还要考虑任务栏的位置。因为 + // 如果窗口最大化后，其尺寸和屏幕尺寸相等（因为任务栏隐藏了，所以窗口最大化 + // 后其实是充满了整个屏幕，变相的全屏了），Windows会认为窗口已经进入全屏的 + // 状态，从而导致自动隐藏的任务栏无法弹出。要避免这个状况，就要使窗口的尺寸 + // 小于屏幕尺寸。我下面的做法，参考了火狐和Chromium。但是如果没有开启任务 + // 栏自动隐藏，是不存在这个问题的，所以要先进行判断。 + // 一般情况下，*result设置为0（相当于DefWindowProc的返回值为0）就可以了， + // 根据MSDN的说法，返回0意为此消息已经被程序自行处理了，让Windows跳过此消 + // 息，否则Windows会添加对此消息的默认处理，对于当前这个消息而言，就意味着 + // 标题栏和窗口边框又会回来，这当然不是我们想要的结果。根据MSDN，当wParam + // 为FALSE时，只能返回0，但当其为TRUE时，可以返回0，也可以返回一个WVR_常 + // 量。根据Chromium的注释，当存在非客户区时，如果返回WVR_REDRAW会导致子 + // 窗口/子控件出现奇怪的bug（自绘控件错位），并且Lucas在Windows + // 10上成 + // 功复现，说明这个bug至今都没有解决。因为这个是Windows自身的bug，且已经 + // 存在很久，这种情况下只有返回0才能规避这个问题。但如果不存在非客户区，且 + // wParam为TRUE，最好返回WVR_REDRAW，否则窗口在调整大小可能会产生严重的 + // 闪烁现象。 + // 虽然对大多数消息来说，返回0都代表让Windows忽略此消息，但实际上不同消息 + // 能接受的返回值是不一样的，请注意自行查阅MSDN。 + + // Sent when the size and position of a window's client area must be + // calculated. By processing this message, an application can + // control the content of the window's client area when the size or + // position of the window changes. If wParam is TRUE, lParam points + // to an NCCALCSIZE_PARAMS structure that contains information an + // application can use to calculate the new size and position of the + // client rectangle. If wParam is FALSE, lParam points to a RECT + // structure. On entry, the structure contains the proposed window + // rectangle for the window. On exit, the structure should contain + // the screen coordinates of the corresponding window client area. + const auto mode = static_cast(msg->wParam); + // If the window bounds change, we're going to relayout and repaint + // anyway. Returning WVR_REDRAW avoids an extra paint before that of + // the old client pixels in the (now wrong) location, and thus makes + // actions like resizing a window from the left edge look slightly + // less broken. + *result = mode ? WVR_REDRAW : 0; + const auto clientRect = mode + ? &(reinterpret_cast(msg->lParam)->rgrc[0]) + : reinterpret_cast(msg->lParam); + // Store the original top before the default window proc applies the + // default frame. + const LONG originalTop = clientRect->top; + // Apply the default frame + const LRESULT ret = m_lpDefWindowProcW(msg->hwnd, WM_NCCALCSIZE, + msg->wParam, msg->lParam); + if (ret != 0) { + *result = ret; + return true; + } + // Re-apply the original top from before the size of the default + // frame was applied. + clientRect->top = originalTop; + // We don't need this correction when we're fullscreen. We will have + // the WS_POPUP size, so we don't have to worry about borders, and + // the default frame will be fine. + if (IsMaximized(msg->hwnd) && !IsFullScreen(msg->hwnd)) { + // When a window is maximized, its size is actually a little bit + // more than the monitor's work area. The window is positioned + // and sized in such a way that the resize handles are outside + // of the monitor and then the window is clipped to the monitor + // so that the resize handle do not appear because you don't + // need them (because you can't resize a window when it's + // maximized unless you restore it). + clientRect->top += GetFrameSizeForWindow(msg->hwnd).top; + } + // Attempt to detect if there's an autohide taskbar, and if + // there is, reduce our size a bit on the side with the taskbar, + // so the user can still mouse-over the taskbar to reveal it. + // Make sure to use MONITOR_DEFAULTTONEAREST, so that this will + // still find the right monitor even when we're restoring from + // minimized. + if (IsMaximized(msg->hwnd)) { + APPBARDATA abd; + SecureZeroMemory(&abd, sizeof(abd)); + abd.cbSize = sizeof(abd); + const UINT taskbarState = + m_lpSHAppBarMessage(ABM_GETSTATE, &abd); + // First, check if we have an auto-hide taskbar at all: + if (taskbarState & ABS_AUTOHIDE) { + const HMONITOR windowMonitor = m_lpMonitorFromWindow( + msg->hwnd, MONITOR_DEFAULTTONEAREST); + bool top = false, bottom = false, left = false, + right = false; + // Due to ABM_GETAUTOHIDEBAREX only exists from Win8.1, + // we have to use another way to judge this if we are + // running on Windows 7 or Windows 8. + if (QOperatingSystemVersion::current() >= + QOperatingSystemVersion::Windows8_1) { + MONITORINFO monitorInfo; + SecureZeroMemory(&monitorInfo, sizeof(monitorInfo)); + monitorInfo.cbSize = sizeof(monitorInfo); + m_lpGetMonitorInfoW(windowMonitor, &monitorInfo); + // This helper can be used to determine if there's a + // auto-hide taskbar on the given edge of the monitor + // we're currently on. + const auto hasAutohideTaskbar = + [&monitorInfo](const UINT edge) -> bool { + APPBARDATA _abd; + SecureZeroMemory(&_abd, sizeof(_abd)); + _abd.cbSize = sizeof(_abd); + _abd.uEdge = edge; + _abd.rc = monitorInfo.rcMonitor; + const auto hTaskbar = + reinterpret_cast(m_lpSHAppBarMessage( + ABM_GETAUTOHIDEBAREX, &_abd)); + return hTaskbar != nullptr; + }; + top = hasAutohideTaskbar(ABE_TOP); + bottom = hasAutohideTaskbar(ABE_BOTTOM); + left = hasAutohideTaskbar(ABE_LEFT); + right = hasAutohideTaskbar(ABE_RIGHT); + } else { + // The following code is copied from Mozilla Firefox, + // with some modifications. + int edge = -1; + APPBARDATA _abd; + SecureZeroMemory(&_abd, sizeof(_abd)); + _abd.cbSize = sizeof(_abd); + _abd.hWnd = m_lpFindWindowW(L"Shell_TrayWnd", nullptr); + if (_abd.hWnd) { + const HMONITOR taskbarMonitor = + m_lpMonitorFromWindow(_abd.hWnd, + MONITOR_DEFAULTTOPRIMARY); + if (taskbarMonitor == windowMonitor) { + m_lpSHAppBarMessage(ABM_GETTASKBARPOS, &_abd); + edge = _abd.uEdge; + } + } + top = edge == ABE_TOP; + bottom = edge == ABE_BOTTOM; + left = edge == ABE_LEFT; + right = edge == ABE_RIGHT; + } + // If there's a taskbar on any side of the monitor, reduce + // our size a little bit on that edge. + // Note to future code archeologists: + // This doesn't seem to work for fullscreen on the primary + // display. However, testing a bunch of other apps with + // fullscreen modes and an auto-hiding taskbar has + // shown that _none_ of them reveal the taskbar from + // fullscreen mode. This includes Edge, Firefox, Chrome, + // Sublime Text, PowerPoint - none seemed to support this. + // This does however work fine for maximized. + if (top) { + // Peculiarly, when we're fullscreen, + clientRect->top += kAutoHideTaskbarThicknessPy; + } else if (bottom) { + clientRect->bottom -= kAutoHideTaskbarThicknessPy; + } else if (left) { + clientRect->left += kAutoHideTaskbarThicknessPx; + } else if (right) { + clientRect->right -= kAutoHideTaskbarThicknessPx; + } + } + // We cannot return WVR_REDRAW when there is nonclient area, or + // Windows exhibits bugs where client pixels and child HWNDs are + // mispositioned by the width/height of the upper-left nonclient + // area. + *result = 0; + } + return true; + } + case WM_NCUAHDRAWCAPTION: + case WM_NCUAHDRAWFRAME: { + // These undocumented messages are sent to draw themed window + // borders. Block them to prevent drawing borders over the client + // area. + *result = 0; + return true; + } + case WM_NCACTIVATE: { + // DefWindowProc won't repaint the window border if lParam (normally + // a HRGN) is -1. + // Don't use "*result = 0" otherwise the window won't respond to + // the window active state change. + *result = + m_lpDefWindowProcW(msg->hwnd, msg->message, msg->wParam, -1); + return true; + } + case WM_NCHITTEST: { + if (dwmHitResult != 0) { + break; + } + if (data->windowData.mouseTransparent) { + *result = HTTRANSPARENT; + return true; + } + // This will handle the left, right and bottom parts of the frame + // because we didn't change them. + const LRESULT originalRet = m_lpDefWindowProcW( + msg->hwnd, WM_NCHITTEST, msg->wParam, msg->lParam); + if (originalRet != HTCLIENT) { + *result = originalRet; + return true; + } + // At this point, we know that the cursor is inside the client area + // so it has to be either the little border at the top of our custom + // title bar or the drag bar. Apparently, it must be the drag bar or + // the little border at the top which the user can use to move or + // resize the window. + RECT rcWindow = {0, 0, 0, 0}; + // Only GetWindowRect can give us the most accurate size of our + // window which includes the invisible resize area. + m_lpGetWindowRect(msg->hwnd, &rcWindow); + // Don't use HIWORD or LOWORD because they can only get positive + // results, however, the cursor coordinates can be negative due to + // in a different monitor. + const LONG my = GET_Y_LPARAM(msg->lParam); + // The top of the drag bar is used to resize the window + if (!IsMaximized(msg->hwnd) && + (my < (rcWindow.top + GetFrameSizeForWindow(msg->hwnd).top))) { + *result = HTTOP; + return true; + } + if (my < + (rcWindow.top + GetFrameSizeForWindow(msg->hwnd, true).top)) { + *result = HTCAPTION; + return true; + } + *result = HTCLIENT; + return true; + } + case WM_SETICON: + case WM_SETTEXT: { + // Disable painting while these messages are handled to prevent them + // from drawing a window caption over the client area. + const auto oldStyle = m_lpGetWindowLongPtrW(msg->hwnd, GWL_STYLE); + // Prevent Windows from drawing the default title bar by temporarily + // toggling the WS_VISIBLE style. + m_lpSetWindowLongPtrW(msg->hwnd, GWL_STYLE, oldStyle & ~WS_VISIBLE); + updateWindow(msg->hwnd, true, false); + const LRESULT ret = m_lpDefWindowProcW(msg->hwnd, msg->message, + msg->wParam, msg->lParam); + m_lpSetWindowLongPtrW(msg->hwnd, GWL_STYLE, oldStyle); + updateWindow(msg->hwnd, true, false); + *result = ret; + return true; + } + case WM_ACTIVATE: + case WM_DWMCOMPOSITIONCHANGED: { + UpdateFrameMarginsForWindow(msg->hwnd); + break; + } + case WM_NCPAINT: { + if (IsDwmCompositionEnabled()) { + break; + } else { + // Only block WM_NCPAINT when DWM composition is disabled. If + // it's blocked when DWM composition is enabled, the frame + // shadow won't be drawn. + *result = 0; + return true; + } + } +#if 0 + case WM_PAINT: { + PAINTSTRUCT ps; + const HDC hdc = m_lpBeginPaint(msg->hwnd, &ps); + const LONG topBorderHeight = 1; + if (ps.rcPaint.top < topBorderHeight) { + RECT rcTopBorder = ps.rcPaint; + rcTopBorder.bottom = topBorderHeight; + // To show the original top border, we have to paint on top + // of it with the alpha component set to 0. This page + // recommends to paint the area in black using the stock + // BLACK_BRUSH to do this: + // https://docs.microsoft.com/en-us/windows/win32/dwm/customframe#extending-the-client-frame + m_lpFillRect(hdc, &rcTopBorder, GetStockBrush(BLACK_BRUSH)); + } + if (ps.rcPaint.bottom > topBorderHeight) { + RECT rcRest = ps.rcPaint; + rcRest.top = topBorderHeight; + // To hide the original title bar, we have to paint on top + // of it with the alpha component set to 255. This is a hack + // to do it with GDI. See UpdateFrameMarginsForWindow for + // more information. + HDC opaqueDc; + BP_PAINTPARAMS params; + SecureZeroMemory(¶ms, sizeof(params)); + params.cbSize = sizeof(params); + params.dwFlags = BPPF_NOCLIP | BPPF_ERASE; + const HPAINTBUFFER buf = m_lpBeginBufferedPaint( + hdc, &rcRest, BPBF_TOPDOWNDIB, ¶ms, &opaqueDc); + m_lpFillRect(opaqueDc, &rcRest, + reinterpret_cast(m_lpGetClassLongPtrW( + msg->hwnd, GCLP_HBRBACKGROUND))); + m_lpBufferedPaintSetAlpha(buf, nullptr, 255); + m_lpEndBufferedPaint(buf, TRUE); + } + m_lpEndPaint(msg->hwnd, &ps); + break; + } +#endif + default: { + break; + } + } + } + return false; +} + +void WinNativeEventFilter::setWindowData(HWND window, const WINDOWDATA *data) { + ResolveWin32APIs(); + if (window && m_lpIsWindow(window) && data) { + createUserData(window, data); + } +} + +WinNativeEventFilter::WINDOWDATA * +WinNativeEventFilter::windowData(HWND window) { + ResolveWin32APIs(); + if (window && m_lpIsWindow(window)) { + createUserData(window); + return &reinterpret_cast( + m_lpGetWindowLongPtrW(window, GWLP_USERDATA)) + ->windowData; + } + return nullptr; +} + +void WinNativeEventFilter::setBorderWidth(int bw) { m_borderWidth = bw; } + +void WinNativeEventFilter::setBorderHeight(int bh) { m_borderHeight = bh; } + +void WinNativeEventFilter::setTitlebarHeight(int tbh) { + m_titlebarHeight = tbh; +} + void WinNativeEventFilter::updateWindow(HWND handle, bool triggerFrameChange, bool redraw) { - initWin32Api(); + ResolveWin32APIs(); if (handle && m_lpIsWindow(handle)) { if (triggerFrameChange) { m_lpSetWindowPos(handle, nullptr, 0, 0, 0, 0, @@ -1103,8 +1134,8 @@ void WinNativeEventFilter::updateWindow(HWND handle, bool triggerFrameChange, int WinNativeEventFilter::getSystemMetric(HWND handle, SystemMetric metric, bool dpiAware) { - initWin32Api(); - const qreal dpr = dpiAware ? getDevicePixelRatioForWindow(handle) + ResolveWin32APIs(); + const qreal dpr = dpiAware ? GetDevicePixelRatioForWindow(handle) : m_defaultDevicePixelRatio; if (handle && m_lpIsWindow(handle)) { createUserData(handle); @@ -1115,22 +1146,42 @@ int WinNativeEventFilter::getSystemMetric(HWND handle, SystemMetric metric, const int bw = userData->windowData.borderWidth; if (bw > 0) { return std::round(bw * dpr); + } else { + const int result = m_lpGetSystemMetrics(SM_CXSIZEFRAME) + + m_lpGetSystemMetrics(SM_CXPADDEDBORDER); + const int result_dpi = + GetSystemMetricsForWindow(handle, SM_CXSIZEFRAME) + + GetSystemMetricsForWindow(handle, SM_CXPADDEDBORDER); + return dpiAware ? result_dpi : result; } - break; } case SystemMetric::BorderHeight: { const int bh = userData->windowData.borderHeight; if (bh > 0) { return std::round(bh * dpr); + } else { + const int result = m_lpGetSystemMetrics(SM_CYSIZEFRAME) + + m_lpGetSystemMetrics(SM_CXPADDEDBORDER); + const int result_dpi = + GetSystemMetricsForWindow(handle, SM_CYSIZEFRAME) + + GetSystemMetricsForWindow(handle, SM_CXPADDEDBORDER); + return dpiAware ? result_dpi : result; } - break; } case SystemMetric::TitleBarHeight: { const int tbh = userData->windowData.titlebarHeight; if (tbh > 0) { return std::round(tbh * dpr); + } else { + const int result = m_lpGetSystemMetrics(SM_CYSIZEFRAME) + + m_lpGetSystemMetrics(SM_CXPADDEDBORDER) + + m_lpGetSystemMetrics(SM_CYCAPTION); + const int result_dpi = + GetSystemMetricsForWindow(handle, SM_CYSIZEFRAME) + + GetSystemMetricsForWindow(handle, SM_CXPADDEDBORDER) + + GetSystemMetricsForWindow(handle, SM_CYCAPTION); + return dpiAware ? result_dpi : result; } - break; } } } @@ -1138,40 +1189,20 @@ int WinNativeEventFilter::getSystemMetric(HWND handle, SystemMetric metric, case SystemMetric::BorderWidth: { if (m_borderWidth > 0) { return std::round(m_borderWidth * dpr); - } else { - const int result = m_lpGetSystemMetrics(SM_CXSIZEFRAME) + - m_lpGetSystemMetrics(SM_CXPADDEDBORDER); - const int result_dpi = - getSystemMetricsForWindow(handle, SM_CXSIZEFRAME) + - getSystemMetricsForWindow(handle, SM_CXPADDEDBORDER); - return dpiAware ? result_dpi : result; } + break; } case SystemMetric::BorderHeight: { if (m_borderHeight > 0) { return std::round(m_borderHeight * dpr); - } else { - const int result = m_lpGetSystemMetrics(SM_CYSIZEFRAME) + - m_lpGetSystemMetrics(SM_CXPADDEDBORDER); - const int result_dpi = - getSystemMetricsForWindow(handle, SM_CYSIZEFRAME) + - getSystemMetricsForWindow(handle, SM_CXPADDEDBORDER); - return dpiAware ? result_dpi : result; } + break; } case SystemMetric::TitleBarHeight: { if (m_titlebarHeight > 0) { return std::round(m_titlebarHeight * dpr); - } else { - const int result = m_lpGetSystemMetrics(SM_CYSIZEFRAME) + - m_lpGetSystemMetrics(SM_CXPADDEDBORDER) + - m_lpGetSystemMetrics(SM_CYCAPTION); - const int result_dpi = - getSystemMetricsForWindow(handle, SM_CYSIZEFRAME) + - getSystemMetricsForWindow(handle, SM_CXPADDEDBORDER) + - getSystemMetricsForWindow(handle, SM_CYCAPTION); - return dpiAware ? result_dpi : result; } + break; } } return -1; diff --git a/winnativeeventfilter.h b/winnativeeventfilter.h index 45c8ea2..762dfb8 100644 --- a/winnativeeventfilter.h +++ b/winnativeeventfilter.h @@ -41,7 +41,6 @@ public: BOOL fixedSize = FALSE, mouseTransparent = FALSE; int borderWidth = -1, borderHeight = -1, titlebarHeight = -1; QVector ignoreAreas, draggableAreas; - QSize maximumSize = {-1, -1}, minimumSize = {-1, -1}; }; using WINDOW = struct _WINDOW { @@ -101,13 +100,4 @@ public: bool nativeEventFilter(const QByteArray &eventType, void *message, long *result) override; #endif - -private: - static void initWin32Api(); - static void createUserData(HWND handle, const WINDOWDATA *data = nullptr); - static void updateGlass(HWND handle); - static qreal getPreferedNumber(qreal num); - static UINT getDotsPerInchForWindow(HWND handle); - static qreal getDevicePixelRatioForWindow(HWND handle); - static int getSystemMetricsForWindow(HWND handle, int index); };