diff --git a/framelesshelper.cpp b/framelesshelper.cpp index 204ee11..8ac0391 100644 --- a/framelesshelper.cpp +++ b/framelesshelper.cpp @@ -84,7 +84,7 @@ void FramelessHelper::updateQtFrame(QWindow *const window, // window. window->setProperty("_q_windowsCustomMargins", marginsVar); // If a platform window exists, change via native interface. - QPlatformWindow *platformWindow = window->handle(); + QPlatformWindow *const platformWindow = window->handle(); if (platformWindow) { QGuiApplication::platformNativeInterface()->setWindowProperty( platformWindow, QString::fromUtf8("WindowsCustomMargins"), @@ -204,7 +204,7 @@ void FramelessHelper::removeWindowFrame(QObject *const obj) { if (obj) { // Don't miss the Qt::Window flag. const Qt::WindowFlags flags = Qt::Window | Qt::FramelessWindowHint; - QWindow *window = getWindowHandle(obj); + QWindow *const window = getWindowHandle(obj); if (window) { window->setFlags(flags); // MouseTracking is always enabled for QWindow. @@ -418,7 +418,7 @@ bool FramelessHelper::eventFilter(QObject *object, QEvent *event) { const auto moveOrResize = [&getWindowEdges, &isResizePermitted, &isInTitlebarArea](const QPointF &point, QObject *const object) { - QWindow *window = getWindowHandle(object); + QWindow *const window = getWindowHandle(object); if (window) { const Qt::Edges edges = getWindowEdges(point, window->width(), window->height()); @@ -500,7 +500,7 @@ bool FramelessHelper::eventFilter(QObject *object, QEvent *event) { case QEvent::MouseMove: { const auto mouseEvent = static_cast(event); if (mouseEvent) { - QWindow *window = getWindowHandle(object); + QWindow *const window = getWindowHandle(object); if (window) { if (window->windowStates().testFlag( Qt::WindowState::WindowNoState)) { diff --git a/winnativeeventfilter.cpp b/winnativeeventfilter.cpp index a729343..dc6e5b1 100644 --- a/winnativeeventfilter.cpp +++ b/winnativeeventfilter.cpp @@ -1682,7 +1682,7 @@ void WinNativeEventFilter::updateQtFrame(QWindow *const window, // window. window->setProperty("_q_windowsCustomMargins", marginsVar); // If a platform window exists, change via native interface. - QPlatformWindow *platformWindow = window->handle(); + QPlatformWindow *const platformWindow = window->handle(); if (platformWindow) { QGuiApplication::platformNativeInterface()->setWindowProperty( platformWindow, QString::fromUtf8("WindowsCustomMargins"), @@ -1707,6 +1707,12 @@ void WinNativeEventFilter::updateQtFrame_internal(const HWND handle) { } } #endif + // ### FIXME: Doesn't really work for QWindow. + // How to get the corresponding QWindow from + // it's window handle? Most blogs on the Internet + // say use QWindow::fromWinId(), but it doesn't + // work as expected. We can get a QWindow, but + // it's not the QWindow we created. QWindow *const window = QWindow::fromWinId(wid); if (window) { updateQtFrame(window, tbh);