Compare commits

..

No commits in common. "ee92e3d89429d71e97b1ddee472b9ccaa22cffc2" and "b9238440e0a199058cddd4a712e24021809ddab7" have entirely different histories.

22 changed files with 136 additions and 177 deletions

View File

@ -122,7 +122,7 @@ Q_SIGNALS:
void chromeButtonColorChanged(); void chromeButtonColorChanged();
private: private:
const QScopedPointer<ChromePalettePrivate> d_ptr; QScopedPointer<ChromePalettePrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -30,26 +30,21 @@
FRAMELESSHELPER_BEGIN_NAMESPACE FRAMELESSHELPER_BEGIN_NAMESPACE
class FramelessHelperQtPrivate;
class FRAMELESSHELPER_CORE_API FramelessHelperQt : public QObject class FRAMELESSHELPER_CORE_API FramelessHelperQt : public QObject
{ {
Q_OBJECT Q_OBJECT
FRAMELESSHELPER_CLASS_INFO FRAMELESSHELPER_CLASS_INFO
Q_DISABLE_COPY_MOVE(FramelessHelperQt) Q_DISABLE_COPY_MOVE(FramelessHelperQt)
Q_DECLARE_PRIVATE(FramelessHelperQt)
public: public:
explicit FramelessHelperQt(QObject *parent = nullptr); explicit FramelessHelperQt(QObject *parent = nullptr);
~FramelessHelperQt() override; ~FramelessHelperQt() override;
static void addWindow(const QObject *window); static void addWindow(const QWindow *window);
static void removeWindow(const QObject *window); static void removeWindow(const QWindow *window);
protected: protected:
Q_NODISCARD bool eventFilter(QObject *object, QEvent *event) override; Q_NODISCARD bool eventFilter(QObject *object, QEvent *event) override;
private:
const QScopedPointer<FramelessHelperQtPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -63,7 +63,7 @@ private:
~FramelessManager() override; ~FramelessManager() override;
private: private:
const QScopedPointer<FramelessManagerPrivate> d_ptr; QScopedPointer<FramelessManagerPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -82,7 +82,7 @@ Q_SIGNALS:
void shouldRedraw(); void shouldRedraw();
private: private:
const QScopedPointer<MicaMaterialPrivate> d_ptr; QScopedPointer<MicaMaterialPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -134,7 +134,7 @@ struct FRAMELESSHELPER_CORE_API FramelessData
{ {
QObject *window = nullptr; QObject *window = nullptr;
WId windowId = 0; WId windowId = 0;
QObject *eventFilter = nullptr; QObject *winIdUpdater = nullptr;
bool frameless = false; bool frameless = false;
FramelessCallbacksPtr callbacks = nullptr; FramelessCallbacksPtr callbacks = nullptr;
FramelessExtraDataHash extraData = {}; FramelessExtraDataHash extraData = {};

View File

@ -125,6 +125,7 @@ namespace Utils
[[nodiscard]] FRAMELESSHELPER_CORE_API bool bringWindowToFront(const WId windowId); [[nodiscard]] FRAMELESSHELPER_CORE_API bool bringWindowToFront(const WId windowId);
[[nodiscard]] FRAMELESSHELPER_CORE_API QPoint getWindowPlacementOffset(const WId windowId); [[nodiscard]] FRAMELESSHELPER_CORE_API QPoint getWindowPlacementOffset(const WId windowId);
[[nodiscard]] FRAMELESSHELPER_CORE_API QRect getWindowRestoreGeometry(const WId windowId); [[nodiscard]] FRAMELESSHELPER_CORE_API QRect getWindowRestoreGeometry(const WId windowId);
[[nodiscard]] FRAMELESSHELPER_CORE_API bool removeMicaWindow(const WId windowId);
[[nodiscard]] FRAMELESSHELPER_CORE_API quint64 getKeyState(); [[nodiscard]] FRAMELESSHELPER_CORE_API quint64 getKeyState();
[[nodiscard]] FRAMELESSHELPER_CORE_API bool isValidWindow(const WId windowId, const bool checkVisible, const bool checkTopLevel); [[nodiscard]] FRAMELESSHELPER_CORE_API bool isValidWindow(const WId windowId, const bool checkVisible, const bool checkTopLevel);
[[nodiscard]] FRAMELESSHELPER_CORE_API bool updateFramebufferTransparency(const WId windowId); [[nodiscard]] FRAMELESSHELPER_CORE_API bool updateFramebufferTransparency(const WId windowId);

View File

@ -79,7 +79,7 @@ Q_SIGNALS:
void shouldRepaint(); void shouldRepaint();
private: private:
const QScopedPointer<WindowBorderPainterPrivate> d_ptr; QScopedPointer<WindowBorderPainterPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -111,7 +111,7 @@ Q_SIGNALS:
void ready(); void ready();
private: private:
const QScopedPointer<FramelessQuickHelperPrivate> d_ptr; QScopedPointer<FramelessQuickHelperPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -79,7 +79,7 @@ Q_SIGNALS:
void fullScreenChanged(); void fullScreenChanged();
private: private:
const QScopedPointer<FramelessQuickApplicationWindowPrivate> d_ptr; QScopedPointer<FramelessQuickApplicationWindowPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -79,7 +79,7 @@ Q_SIGNALS:
void fullScreenChanged(); void fullScreenChanged();
private: private:
const QScopedPointer<FramelessQuickWindowPrivate> d_ptr; QScopedPointer<FramelessQuickWindowPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -83,7 +83,7 @@ protected:
void componentComplete() override; void componentComplete() override;
private: private:
const QScopedPointer<QuickMicaMaterialPrivate> d_ptr; QScopedPointer<QuickMicaMaterialPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -88,7 +88,7 @@ Q_SIGNALS:
void nativeBorderChanged(); void nativeBorderChanged();
private: private:
const QScopedPointer<QuickWindowBorderPrivate> d_ptr; QScopedPointer<QuickWindowBorderPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -45,7 +45,7 @@ public:
~FramelessDialog() override; ~FramelessDialog() override;
private: private:
const QScopedPointer<FramelessDialogPrivate> d_ptr; QScopedPointer<FramelessDialogPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -60,7 +60,7 @@ Q_SIGNALS:
void zoomedChanged(); void zoomedChanged();
private: private:
const QScopedPointer<FramelessMainWindowPrivate> d_ptr; QScopedPointer<FramelessMainWindowPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -60,7 +60,7 @@ Q_SIGNALS:
void zoomedChanged(); void zoomedChanged();
private: private:
const QScopedPointer<FramelessWidgetPrivate> d_ptr; QScopedPointer<FramelessWidgetPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -98,7 +98,7 @@ Q_SIGNALS:
void ready(); void ready();
private: private:
const QScopedPointer<FramelessWidgetsHelperPrivate> d_ptr; QScopedPointer<FramelessWidgetsHelperPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -91,7 +91,7 @@ Q_SIGNALS:
void glyphSizeChanged(); void glyphSizeChanged();
private: private:
const QScopedPointer<StandardSystemButtonPrivate> d_ptr; QScopedPointer<StandardSystemButtonPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -106,7 +106,7 @@ Q_SIGNALS:
void titleFontChanged(); void titleFontChanged();
private: private:
const QScopedPointer<StandardTitleBarPrivate> d_ptr; QScopedPointer<StandardTitleBarPrivate> d_ptr;
}; };
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE

View File

@ -52,83 +52,37 @@ FRAMELESSHELPER_BEGIN_NAMESPACE
using namespace Global; using namespace Global;
using FramelessHelperQtPtr = std::shared_ptr<FramelessHelperQt>;
#define CreateFramelessHelperQt(...) std::make_shared<FramelessHelperQt>(__VA_ARGS__)
struct FramelessDataQt : public FramelessData struct FramelessDataQt : public FramelessData
{ {
FramelessHelperQt *eventFilter = nullptr; FramelessHelperQtPtr eventFilter = nullptr;
bool cursorShapeChanged = false; bool cursorShapeChanged = false;
bool leftButtonPressed = false; bool leftButtonPressed = false;
FramelessDataQt();
~FramelessDataQt() override;
}; };
using FramelessDataQtPtr = std::shared_ptr<FramelessDataQt>; using FramelessDataQtPtr = std::shared_ptr<FramelessDataQt>;
#define CreateFramelessDataQt(...) std::make_shared<FramelessDataQt>(__VA_ARGS__)
class FramelessHelperQtPrivate : public QObject [[nodiscard]] FramelessDataQtPtr CreateEmptyDataQt() { return CreateFramelessDataQt(); }
{
Q_OBJECT
FRAMELESSHELPER_CLASS_INFO
Q_DISABLE_COPY_MOVE(FramelessHelperQtPrivate)
Q_DECLARE_PUBLIC(FramelessHelperQt)
public: FramelessHelperQt::FramelessHelperQt(QObject *parent) : QObject(parent) {}
explicit FramelessHelperQtPrivate(FramelessHelperQt *q);
~FramelessHelperQtPrivate() override;
FramelessHelperQt *q_ptr = nullptr;
const QObject *window = nullptr;
};
[[nodiscard]] static inline FramelessDataQtPtr tryGetData(const QObject *window)
{
Q_ASSERT(window);
if (!window) {
return nullptr;
}
const FramelessDataPtr data = FramelessManagerPrivate::getData(window);
if (!data) {
return nullptr;
}
return std::dynamic_pointer_cast<FramelessDataQt>(data);
}
FramelessDataQt::FramelessDataQt() = default;
FramelessDataQt::~FramelessDataQt() = default;
[[nodiscard]] FramelessDataPtr FramelessData::create()
{
return std::make_shared<FramelessDataQt>();
}
FramelessHelperQtPrivate::FramelessHelperQtPrivate(FramelessHelperQt *q) : QObject(q), q_ptr(q)
{
}
FramelessHelperQtPrivate::~FramelessHelperQtPrivate() = default;
FramelessHelperQt::FramelessHelperQt(QObject *parent) : QObject(parent), d_ptr(new FramelessHelperQtPrivate(this))
{
}
FramelessHelperQt::~FramelessHelperQt() = default; FramelessHelperQt::~FramelessHelperQt() = default;
void FramelessHelperQt::addWindow(const QObject *window) void FramelessHelperQt::addWindow(const QWindow *window)
{ {
Q_ASSERT(window); Q_ASSERT(window);
if (!window) { if (!window) {
return; return;
} }
const FramelessDataQtPtr data = tryGetData(window); const auto data = std::dynamic_pointer_cast<FramelessDataQt>(FramelessManagerPrivate::getData(window));
if (!data || data->frameless || !data->callbacks) { Q_ASSERT(data->callbacks);
if (!data->callbacks) {
return; return;
} }
QWindow *qWindow = data->callbacks->getWindowHandle(); data->eventFilter = CreateFramelessHelperQt();
Q_ASSERT(qWindow); const auto shouldApplyFramelessFlag = []() -> bool {
if (!qWindow) {
return;
}
data->frameless = true;
static const auto shouldApplyFramelessFlag = []() -> bool {
#ifdef Q_OS_MACOS #ifdef Q_OS_MACOS
return false; return false;
#elif (defined(Q_OS_LINUX) && !defined(Q_OS_ANDROID)) #elif (defined(Q_OS_LINUX) && !defined(Q_OS_ANDROID))
@ -138,46 +92,35 @@ void FramelessHelperQt::addWindow(const QObject *window)
#endif // Q_OS_MACOS #endif // Q_OS_MACOS
}(); }();
#if (defined(Q_OS_MACOS) && (QT_VERSION < QT_VERSION_CHECK(6, 0, 0))) #if (defined(Q_OS_MACOS) && (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)))
qWindow->setProperty("_q_mac_wantsLayer", 1); window->setProperty("_q_mac_wantsLayer", 1);
#endif // (defined(Q_OS_MACOS) && (QT_VERSION < QT_VERSION_CHECK(6, 0, 0))) #endif // (defined(Q_OS_MACOS) && (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)))
if (shouldApplyFramelessFlag) { if (shouldApplyFramelessFlag) {
data->callbacks->setWindowFlags(data->callbacks->getWindowFlags() | Qt::FramelessWindowHint); data->callbacks->setWindowFlags(data->callbacks->getWindowFlags() | Qt::FramelessWindowHint);
} else { } else {
#if (defined(Q_OS_LINUX) && !defined(Q_OS_ANDROID)) #if (defined(Q_OS_LINUX) && !defined(Q_OS_ANDROID))
std::ignore = Utils::tryHideSystemTitleBar(data->callbacks->getWindowId(), true); std::ignore = Utils::tryHideSystemTitleBar(window, true);
#elif defined(Q_OS_MACOS) #elif defined(Q_OS_MACOS)
Utils::setSystemTitleBarVisible(data->callbacks->getWindowId(), false); Utils::setSystemTitleBarVisible(window, false);
#endif // Q_OS_LINUX #endif // Q_OS_LINUX
} }
if (!data->eventFilter) { const_cast<QWindow *>(window)->installEventFilter(data->eventFilter.get());
data->eventFilter = new FramelessHelperQt(data->window);
data->eventFilter->d_func()->window = window;
qWindow->installEventFilter(data->eventFilter);
}
FramelessHelperEnableThemeAware(); FramelessHelperEnableThemeAware();
} }
void FramelessHelperQt::removeWindow(const QObject *window) void FramelessHelperQt::removeWindow(const QWindow *window)
{ {
Q_ASSERT(window); Q_ASSERT(window);
if (!window) { if (!window) {
return; return;
} }
const FramelessDataQtPtr data = tryGetData(window); const auto data = std::dynamic_pointer_cast<FramelessDataQt>(FramelessManagerPrivate::getData(window));
if (!data || !data->frameless || !data->callbacks) { Q_ASSERT(data->eventFilter);
return;
}
if (data->eventFilter) { if (data->eventFilter) {
QWindow *qWindow = data->callbacks->getWindowHandle(); const_cast<QWindow *>(window)->removeEventFilter(data->eventFilter.get());
Q_ASSERT(qWindow);
if (qWindow) {
qWindow->removeEventFilter(data->eventFilter);
delete data->eventFilter;
data->eventFilter = nullptr; data->eventFilter = nullptr;
} }
}
#ifdef Q_OS_MACOS #ifdef Q_OS_MACOS
Utils::removeWindowProxy(data->callbacks->getWindowId()); Utils::removeWindowProxy(window);
#endif #endif
} }
@ -188,26 +131,22 @@ bool FramelessHelperQt::eventFilter(QObject *object, QEvent *event)
if (!object || !event) { if (!object || !event) {
return false; return false;
} }
Q_D(FramelessHelperQt);
if (!d->window) {
return false;
}
#if (QT_VERSION < QT_VERSION_CHECK(6, 5, 0)) #if (QT_VERSION < QT_VERSION_CHECK(6, 5, 0))
// First detect whether we got a theme change event or not, if so, // First detect whether we got a theme change event or not, if so,
// inform the user the system theme has changed. // inform the user the system theme has changed.
if (Utils::isThemeChangeEvent(event)) { if (Utils::isThemeChangeEvent(event)) {
// Sometimes the FramelessManager instance may be destroyed already. // Sometimes the FramelessManager instance may be destroyed already.
if (FramelessManager *manager = FramelessManager::instance()) { if (FramelessManager * const manager = FramelessManager::instance()) {
if (FramelessManagerPrivate * const managerPriv = FramelessManagerPrivate::get(manager)) { if (FramelessManagerPrivate * const managerPriv = FramelessManagerPrivate::get(manager)) {
managerPriv->notifySystemThemeHasChangedOrNot(); managerPriv->notifySystemThemeHasChangedOrNot();
} }
} }
return false; return QObject::eventFilter(object, event);
} }
#endif // (QT_VERSION < QT_VERSION_CHECK(6, 5, 0)) #endif // (QT_VERSION < QT_VERSION_CHECK(6, 5, 0))
// We are only interested in events that are dispatched to top level windows (not even top level widgets). // We are only interested in events that are dispatched to top level windows.
if (!object->isWindowType()) { if (!object->isWindowType()) {
return false; return QObject::eventFilter(object, event);
} }
const QEvent::Type type = event->type(); const QEvent::Type type = event->type();
// We are only interested in some specific mouse events (plus DPR change event). // We are only interested in some specific mouse events (plus DPR change event).
@ -219,12 +158,10 @@ bool FramelessHelperQt::eventFilter(QObject *object, QEvent *event)
&& (type != QEvent::ScreenChangeInternal) // Qt's internal event to notify screen change and DPR change. && (type != QEvent::ScreenChangeInternal) // Qt's internal event to notify screen change and DPR change.
#endif // (QT_VERSION >= QT_VERSION_CHECK(6, 6, 0)) #endif // (QT_VERSION >= QT_VERSION_CHECK(6, 6, 0))
) { ) {
return false; return QObject::eventFilter(object, event);
}
const FramelessDataQtPtr data = tryGetData(d->window);
if (!data || !data->frameless || !data->callbacks) {
return false;
} }
const auto window = qobject_cast<const QWindow *>(object);
const auto data = std::dynamic_pointer_cast<FramelessDataQt>(FramelessManagerPrivate::getData(window));
#if (QT_VERSION >= QT_VERSION_CHECK(6, 6, 0)) #if (QT_VERSION >= QT_VERSION_CHECK(6, 6, 0))
if (type == QEvent::DevicePixelRatioChange) if (type == QEvent::DevicePixelRatioChange)
#else // QT_VERSION < QT_VERSION_CHECK(6, 6, 0) #else // QT_VERSION < QT_VERSION_CHECK(6, 6, 0)
@ -232,9 +169,8 @@ bool FramelessHelperQt::eventFilter(QObject *object, QEvent *event)
#endif // (QT_VERSION >= QT_VERSION_CHECK(6, 6, 0)) #endif // (QT_VERSION >= QT_VERSION_CHECK(6, 6, 0))
{ {
data->callbacks->forceChildrenRepaint(500); data->callbacks->forceChildrenRepaint(500);
return false; return QObject::eventFilter(object, event);
} }
const auto qWindow = qobject_cast<QWindow *>(object);
const auto mouseEvent = static_cast<QMouseEvent *>(event); const auto mouseEvent = static_cast<QMouseEvent *>(event);
const Qt::MouseButton button = mouseEvent->button(); const Qt::MouseButton button = mouseEvent->button();
#if (QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)) #if (QT_VERSION >= QT_VERSION_CHECK(6, 0, 0))
@ -254,9 +190,9 @@ bool FramelessHelperQt::eventFilter(QObject *object, QEvent *event)
if (button == Qt::LeftButton) { if (button == Qt::LeftButton) {
data->leftButtonPressed = true; data->leftButtonPressed = true;
if (!windowFixedSize) { if (!windowFixedSize) {
const Qt::Edges edges = Utils::calculateWindowEdges(qWindow, scenePos); const Qt::Edges edges = Utils::calculateWindowEdges(window, scenePos);
if (edges != Qt::Edges{}) { if (edges != Qt::Edges{}) {
std::ignore = Utils::startSystemResize(qWindow, edges, globalPos); std::ignore = Utils::startSystemResize(const_cast<QWindow *>(window), edges, globalPos);
event->accept(); event->accept();
return true; return true;
} }
@ -287,7 +223,7 @@ bool FramelessHelperQt::eventFilter(QObject *object, QEvent *event)
break; break;
case QEvent::MouseMove: { case QEvent::MouseMove: {
if (!dontOverrideCursor && !windowFixedSize) { if (!dontOverrideCursor && !windowFixedSize) {
const Qt::CursorShape cs = Utils::calculateCursorShape(qWindow, scenePos); const Qt::CursorShape cs = Utils::calculateCursorShape(window, scenePos);
if (cs == Qt::ArrowCursor) { if (cs == Qt::ArrowCursor) {
if (data->cursorShapeChanged) { if (data->cursorShapeChanged) {
data->callbacks->unsetCursor(); data->callbacks->unsetCursor();
@ -300,7 +236,7 @@ bool FramelessHelperQt::eventFilter(QObject *object, QEvent *event)
} }
if (data->leftButtonPressed) { if (data->leftButtonPressed) {
if (!ignoreThisEvent && insideTitleBar) { if (!ignoreThisEvent && insideTitleBar) {
std::ignore = Utils::startSystemMove(qWindow, globalPos); std::ignore = Utils::startSystemMove(const_cast<QWindow *>(window), globalPos);
event->accept(); event->accept();
return true; return true;
} }
@ -309,11 +245,9 @@ bool FramelessHelperQt::eventFilter(QObject *object, QEvent *event)
default: default:
break; break;
} }
return false; return QObject::eventFilter(object, event);
} }
FRAMELESSHELPER_END_NAMESPACE FRAMELESSHELPER_END_NAMESPACE
#include "framelesshelper_qt.moc"
#endif // !native_impl #endif // !native_impl

View File

@ -45,7 +45,6 @@
#include <QtCore/qloggingcategory.h> #include <QtCore/qloggingcategory.h>
#include <QtGui/qfontdatabase.h> #include <QtGui/qfontdatabase.h>
#include <QtGui/qwindow.h> #include <QtGui/qwindow.h>
#include <QtGui/qevent.h>
#if (QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)) #if (QT_VERSION >= QT_VERSION_CHECK(6, 5, 0))
# include <QtGui/qguiapplication.h> # include <QtGui/qguiapplication.h>
# include <QtGui/qstylehints.h> # include <QtGui/qstylehints.h>
@ -106,56 +105,63 @@ Q_GLOBAL_STATIC(InternalData, g_internalData)
} }
#endif #endif
class InternalEventFilter : public QObject class WinIdUpdater : public QObject
{ {
Q_OBJECT Q_OBJECT
FRAMELESSHELPER_CLASS_INFO Q_DISABLE_COPY_MOVE(WinIdUpdater)
Q_DISABLE_COPY_MOVE(InternalEventFilter) Q_PROPERTY(QObject* window READ window WRITE setWindow NOTIFY windowChanged FINAL)
public: public:
explicit InternalEventFilter(const QObject *window, QObject *parent = nullptr); explicit WinIdUpdater(QObject *parent = nullptr);
~InternalEventFilter() override; ~WinIdUpdater() override;
Q_NODISCARD QObject *window() const;
void setWindow(QObject *window);
Q_SIGNALS:
void windowChanged();
protected: protected:
Q_NODISCARD bool eventFilter(QObject *object, QEvent *event) override; Q_NODISCARD bool eventFilter(QObject *object, QEvent *event) override;
private: private:
const QObject *m_window = nullptr; QObject *m_window = nullptr;
}; };
InternalEventFilter::InternalEventFilter(const QObject *window, QObject *parent) : QObject(parent), m_window(window) WinIdUpdater::WinIdUpdater(QObject *parent) : QObject(parent)
{ {
Q_ASSERT(m_window);
Q_ASSERT(m_window->isWidgetType() || m_window->isWindowType());
} }
InternalEventFilter::~InternalEventFilter() = default; WinIdUpdater::~WinIdUpdater() = default;
bool InternalEventFilter::eventFilter(QObject *object, QEvent *event) QObject *WinIdUpdater::window() const
{ {
if (!object || !m_window || (object != m_window)) { return m_window;
return false; }
void WinIdUpdater::setWindow(QObject *window)
{
Q_ASSERT(window);
Q_ASSERT(window->isWidgetType() || window->isWindowType());
if (!window || !(window->isWidgetType() || window->isWindowType()) || (m_window == window)) {
return;
} }
const FramelessDataPtr data = FramelessManagerPrivate::getData(m_window); m_window = window;
if (!data || !data->frameless || !data->callbacks) { Q_EMIT windowChanged();
return false; }
}
switch (event->type()) { bool WinIdUpdater::eventFilter(QObject *object, QEvent *event)
case QEvent::WinIdChange: { {
if (m_window && object && (object == m_window) && (event->type() == QEvent::WinIdChange)) {
if (const FramelessDataPtr data = FramelessManagerPrivate::getData(m_window)) {
if (data->frameless && data->callbacks) {
const WId windowId = data->callbacks->getWindowId(); const WId windowId = data->callbacks->getWindowId();
Q_ASSERT(windowId); Q_ASSERT(windowId);
if (windowId) { if (windowId) {
FramelessManagerPrivate::updateWindowId(m_window, windowId); FramelessManagerPrivate::updateWindowId(m_window, windowId);
} }
} break;
case QEvent::Close: {
const auto ce = static_cast<QCloseEvent *>(event);
if (ce->isAccepted()) {
std::ignore = FramelessManager::instance()->removeWindow(m_window);
} }
} break; }
default:
break;
} }
return false; return false;
} }
@ -318,8 +324,10 @@ FramelessDataPtr FramelessManagerPrivate::createData(const QObject *window, cons
FramelessDataPtr data = FramelessData::create(); FramelessDataPtr data = FramelessData::create();
data->window = win; data->window = win;
data->windowId = windowId; data->windowId = windowId;
data->eventFilter = new InternalEventFilter(data->window, data->window); const auto winIdUpdater = new WinIdUpdater(data->window);
data->window->installEventFilter(data->eventFilter); winIdUpdater->setWindow(data->window);
data->window->installEventFilter(winIdUpdater);
data->winIdUpdater = winIdUpdater;
it = g_internalData()->dataMap.insert(win, data); it = g_internalData()->dataMap.insert(win, data);
g_internalData()->windowMap.insert(windowId, win); g_internalData()->windowMap.insert(windowId, win);
} }
@ -500,9 +508,11 @@ bool FramelessManager::addWindow(const QObject *window, const WId windowId)
g_internalData()->dataMap.insert(data->window, data); g_internalData()->dataMap.insert(data->window, data);
g_internalData()->windowMap.insert(windowId, data->window); g_internalData()->windowMap.insert(windowId, data->window);
} }
if (!data->eventFilter) { if (!data->winIdUpdater) {
data->eventFilter = new InternalEventFilter(data->window, data->window); const auto winIdUpdater = new WinIdUpdater(data->window);
data->window->installEventFilter(data->eventFilter); winIdUpdater->setWindow(data->window);
data->window->installEventFilter(winIdUpdater);
data->winIdUpdater = winIdUpdater;
} }
#if FRAMELESSHELPER_CONFIG(native_impl) #if FRAMELESSHELPER_CONFIG(native_impl)
# ifdef Q_OS_WINDOWS # ifdef Q_OS_WINDOWS
@ -513,11 +523,9 @@ bool FramelessManager::addWindow(const QObject *window, const WId windowId)
# else # else
# endif # endif
#else #else
# ifdef Q_OS_WINDOWS
std::ignore = Utils::installWindowProcHook(windowId);
# endif
FramelessHelperQt::addWindow(window); FramelessHelperQt::addWindow(window);
#endif #endif
connect(window, &QObject::destroyed, FramelessManager::instance(), [this, window](){ std::ignore = removeWindow(window); });
return true; return true;
} }
@ -538,24 +546,22 @@ bool FramelessManager::removeWindow(const QObject *window)
if (!data || !data->window || !data->windowId) { if (!data || !data->window || !data->windowId) {
return false; return false;
} }
if (data->eventFilter) { if (data->winIdUpdater) {
data->window->removeEventFilter(data->eventFilter); data->window->removeEventFilter(data->winIdUpdater);
delete data->eventFilter; data->winIdUpdater->deleteLater();
data->eventFilter = nullptr; data->winIdUpdater = nullptr;
} }
#if FRAMELESSHELPER_CONFIG(native_impl) #if FRAMELESSHELPER_CONFIG(native_impl)
# ifdef Q_OS_WINDOWS # ifdef Q_OS_WINDOWS
FramelessHelperWin::removeWindow(window); FramelessHelperWin::removeWindow(window);
std::ignore = Utils::uninstallWindowProcHook(data->windowId); std::ignore = Utils::uninstallWindowProcHook(data->windowId);
std::ignore = Utils::removeMicaWindow(data->windowId);
# elif (defined(Q_OS_LINUX) && !defined(Q_OS_ANDROID)) # elif (defined(Q_OS_LINUX) && !defined(Q_OS_ANDROID))
# elif defined(Q_OS_MACOS) # elif defined(Q_OS_MACOS)
# else # else
# endif # endif
#else #else
FramelessHelperQt::removeWindow(window); FramelessHelperQt::removeWindow(window);
# ifdef Q_OS_WINDOWS
std::ignore = Utils::uninstallWindowProcHook(data->windowId);
# endif
#endif #endif
g_internalData()->dataMap.erase(it); g_internalData()->dataMap.erase(it);
g_internalData()->windowMap.remove(data->windowId); g_internalData()->windowMap.remove(data->windowId);

View File

@ -218,10 +218,12 @@ bool Utils::moveWindowToDesktopCenter(const WId windowId, const bool considerTas
return false; return false;
} }
const QObject *window = FramelessManagerPrivate::getWindow(windowId); const QObject *window = FramelessManagerPrivate::getWindow(windowId);
Q_ASSERT(window);
if (!window) { if (!window) {
return false; return false;
} }
const FramelessDataPtr data = FramelessManagerPrivate::getData(window); const FramelessDataPtr data = FramelessManagerPrivate::getData(window);
Q_ASSERT(data);
if (!data || !data->callbacks) { if (!data || !data->callbacks) {
return false; return false;
} }
@ -585,7 +587,7 @@ quint32 Utils::defaultScreenDpi()
QColor Utils::getAccentColor() QColor Utils::getAccentColor()
{ {
#if (QT_VERSION >= QT_VERSION_CHECK(6, 6, 0)) #if (QT_VERSION >= QT_VERSION_CHECK(6, 6, 0))
return QGuiApplication::palette().color(QPalette::Accent); return QGuiApplication::palette().color(QPalette::AccentColor);
#else // (QT_VERSION < QT_VERSION_CHECK(6, 6, 0)) #else // (QT_VERSION < QT_VERSION_CHECK(6, 6, 0))
# ifdef Q_OS_WINDOWS # ifdef Q_OS_WINDOWS
return getAccentColor_windows(); return getAccentColor_windows();

View File

@ -923,7 +923,6 @@ static constexpr const std::array<Win32Message, 333> g_win32MessageMap =
if (!qWindow) { if (!qWindow) {
return defaultWindowProcessing(); return defaultWindowProcessing();
} }
#if FRAMELESSHELPER_CONFIG(native_impl)
// https://github.com/qt/qtbase/blob/e26a87f1ecc40bc8c6aa5b889fce67410a57a702/src/plugins/platforms/windows/qwindowscontext.cpp#L1025 // https://github.com/qt/qtbase/blob/e26a87f1ecc40bc8c6aa5b889fce67410a57a702/src/plugins/platforms/windows/qwindowscontext.cpp#L1025
// We can see from the source code that Qt will filter out some messages first and then send the unfiltered // We can see from the source code that Qt will filter out some messages first and then send the unfiltered
// messages to the event dispatcher. To activate the Snap Layout feature on Windows 11, we must process // messages to the event dispatcher. To activate the Snap Layout feature on Windows 11, we must process
@ -972,7 +971,6 @@ static constexpr const std::array<Win32Message, 333> g_win32MessageMap =
return LRESULT(filterResult); return LRESULT(filterResult);
} }
} }
#endif // native_impl
const auto getNativePosFromMouse = [lParam]() -> QPoint { const auto getNativePosFromMouse = [lParam]() -> QPoint {
return {GET_X_LPARAM(lParam), GET_Y_LPARAM(lParam)}; return {GET_X_LPARAM(lParam), GET_Y_LPARAM(lParam)};
}; };
@ -3051,6 +3049,29 @@ QRect Utils::getWindowRestoreGeometry(const WId windowId)
return rect2qrect(wp.rcNormalPosition).translated(getWindowPlacementOffset(windowId)); return rect2qrect(wp.rcNormalPosition).translated(getWindowPlacementOffset(windowId));
} }
bool Utils::removeMicaWindow(const WId windowId)
{
Q_ASSERT(windowId);
if (!windowId) {
return false;
}
const QObject *window = FramelessManagerPrivate::getWindow(windowId);
if (!window) {
return false;
}
const FramelessDataPtr data = FramelessManagerPrivate::getData(window);
if (!data) {
return false;
}
const UtilsWinExtraDataPtr extraData = tryGetExtraData(data, false);
Q_ASSERT(extraData);
if (!extraData || !extraData->mica) {
return false;
}
extraData->mica = false;
return true;
}
quint64 Utils::getKeyState() quint64 Utils::getKeyState()
{ {
quint64 result = 0; quint64 result = 0;